Coder Social home page Coder Social logo

Comments (1)

stuartc avatar stuartc commented on September 21, 2024

This is an interesting one, because the router does correctly redirect users that don't have a session anymore - but it seems like the socket is still connected or at least the "request" is a LiveView request.

In InitAssigns we assume the user is logged in; because "hey that's handled upstream". And I'm not convinced that we should handle redirection there either.

However, the actual line where things break is:

def on_mount(:project_scope, %{"project_id" => project_id}, _session, socket) do
  %{current_user: current_user} = socket.assigns

  project = Lightning.Projects.get_project(project_id)

  projects = Lightning.Projects.get_projects_for_user(current_user) # <= HERE
  #...
end

I think there is quite a bit we can improve with our routing/on_mount hooks here.

But for now I think it would be ok for us to redirect inside the :project_scope hook, if there is no current_user on the socket. I'd recommend pattern matching for it in a clause above the current one.

from lightning.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.