Intermittent problem with API requests returning the source code of index.html instead of the correct data about oed

[RagingOcelot]

I got the error again last night, switching the * to / didn't change anything for me.

However, moving the block to the end fixed it. This is what I have, with it working (for now).

app.use((req, res, next) => {
	const err = new Error('Not Found');
	err.status = 404;
	next(err);
});

app.use((err, req, res) => {
	res.status(err.status || 500);
	if (err.status === 404) res.send(`<h1>${err.status} Not found</h1>`);
	else res.send(`<h1>${err.status} Server Error</h1>`);
});

app.get('*', (req, res) => {
	res.sendFile(path.resolve(__dirname, '..', 'client', 'index.html'));
});

[johndiiorio]

I think this is the correct solution. You should make a pull request.

As of 9/23/17, I do not believe this is the correct solution.

[simonbtomlinson]

I don't think we should close this issue until we merge a pull request that has both a unit test that confirms it and a fix.

[simonbtomlinson]

My bad, I didn't realize that pr was merged

[jameeters]

Well, #245 doesn't include a unit test, although I'm not sure how we would write one for this.