Coder Social home page Coder Social logo

Comments (9)

Hobbydos avatar Hobbydos commented on August 21, 2024

Hi @dplore, would you consider assigning this case to me?

from featureprofiles.

dplore avatar dplore commented on August 21, 2024

Thanks @Hobbydos , I have assigned to you. Please let us know when you expect to send a PR for this test. Thanks!

from featureprofiles.

Hobbydos avatar Hobbydos commented on August 21, 2024

No Problem, just assessing the timeline and will comment with an estimated time.
As for now, it looks like This comment on Issue 64 seems to hint that p4runtime-go-client is the preferred client. One clarification I would like is if there's a preference for featureprofiles to use either p4runtime-go-client or go-p4.

from featureprofiles.

dplore avatar dplore commented on August 21, 2024

Hi, the preferred client is now https://github.com/cisco-open/go-p4. Please use the client for your test implementation. Note, we acknowledge this is a new work and the p4rt tests here are also without much precedent. We welcome feedback on your findings using this client.

from featureprofiles.

Hobbydos avatar Hobbydos commented on August 21, 2024

@dplore

I have a quick question regarding the handling of multiple P4RT tests. P4RT-3.1 and P4RT-3.2, election IDs are being used (0,100=primary), (0,99=secondary) and I've observed that in two different vendor implementations of P4RT, the highest election ID is kept track. When featureprofile tests are ran sequentially, the P4RT server might remember the highest election ID until the P4RT server is restarted. Any following script using lower election ID for its clients will cause the client to fail to be elected as primary. Are there any expectations that users are to handle restarting the P4RT server via bindings file/CI process? If not, is there a proposed alternative?

from featureprofiles.

dplore avatar dplore commented on August 21, 2024

@robshakir @Ankur19 this is a common issue with gRIBI as well. Should we update our tests to have the client assume primary using a methodology like described in the gRIBI spec. Are p4rt and gRIBI elections using the same algorithm?

from featureprofiles.

Hobbydos avatar Hobbydos commented on August 21, 2024

PR #849

from featureprofiles.

Hobbydos avatar Hobbydos commented on August 21, 2024

Renamed the test to "P4RT Election" to be more inclusive.

from featureprofiles.

Hobbydos avatar Hobbydos commented on August 21, 2024

PR849 was merged

from featureprofiles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.