scan-build: objects/pflash/libflash/libflash.c:571,2 Undefined or garbage value returned to caller about skeleton

[williamspatrick]

This code should be deprecated per #19 .

[williamspatrick]

@amboar - Has this been fixed in upstream pflash?

[amboar]

@williamspatrick I haven't checked, but I plan to

[amboar]

@williamspatrick looks to be fixed in skiboot/libflash:

int flash_force_4b_mode(struct flash_chip *c, bool enable_4b)
{
    struct spi_flash_ctrl *ct = c->ctrl;
    int rc = FLASH_ERR_4B_NOT_SUPPORTED;
    ...

[williamspatrick]

Fixed.

[williamspatrick]

(by removal of pflash)