Comments (3)
@tyler-smith you can give your opinion here. I'm not sure I see any logical place to break up the code as it's just initializing everything.
from openbazaar-go.
Yeah almost the bulk of the code is in the server initialization. You could break out logging and command handlers to their own files but I don't think that'd be things much better. You'd still have a giant Start.Execute() that's pretty unavoidable. I don't care too much one way or another if somebody submits a PR with a good refactoring.
from openbazaar-go.
Closing because I mostly agree with Tyler. If someone wants to submit a PR that puts some parts into a separate file I'd be open to it.
from openbazaar-go.
Related Issues (20)
- Bug (GET /ob/sales): Orders with a state of PENDING or RESOLVED have a zero value for total.amount HOT 1
- How to reduce memory usage
- OpenBazaar API return empty price HOT 5
- Switch to Go Modules HOT 2
- Please allow search results to be sorted by origin of shipping HOT 1
- ERROR: create new IPFS node; failed to listen on any address
- compile error:go-multihash is not in GOROOT (/home/linuxbrew/.linuxbrew/Cellar/go/1.14.3/libexec/src/gx/ipfs/QmerPMzPk1mJVowm8KgmoknWa4yCYvvugMPsgWmDNUvDLW/go-multihash) GoWork/pkg/mod/github.com/!open!bazaar/[email protected]/ipfs/resolve.go:15:2: HOT 1
- Config File is Malformed HOT 7
- Unresolved conflict pushed in Godeps.json
- Server crash due to ticker error
- Server crash due to websocket timeout HOT 9
- Dev docker build is not working HOT 1
- (wrong page)
- no log for debugging?
- No sellers appear under pclos - is there a linux this is known to work in? HOT 2
- no obvious way to start this
- Openbazaar HOT 2
- Is openbazaar still alive? HOT 4
- unable to migrate unknown schema HOT 1
- How can I connect to the server once launched (docker)?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openbazaar-go.