REST /api/status always indicate `"IsActiveNode": false` about orchestrator

[shlomi-noach]

I renamed this Issue.

[grierj]

@shlomi-noach As long as we continue to allow custom status url endpoint overrides, I have no problem with splitting the status checks. Square, for instance, has a standard status endpoint that we expect everywhere, so we just need to be able to continue making something respond on it.

[mcrauwel]

I encountered the same issue where /web/status and /api/status did not match.
Setting the StatusSimpleHealth to 'false' solved that issue.

Running version 2.1.4

[shlomi-noach]

This was introduced by @grierj via the StatusSimpleHealth config, in an attempt to reduce load from load balancer checks.

@solutionguy in the meantime please set "StatusSimpleHealth": false in configuration.

@grierj I'm working to change this behavior and remove this config variable. I suggest a completely different URL, such as:

• /api/lb-check (does not run database check)
• /api/db-check (runs the Ping you implemented)

Thoughts?

[solutionguy]

Thanks @shlomi-noach, will test and revert.

[solutionguy]

@shlomi-noach I have tested with StatusSimpleHealth turned off, and it does get the status back correctly via /api/status. Thanks

[shlomi-noach]

Thanks -- yes, this hasn't been fixed yet :(

[choadrocker]

Setting StatusSimpleHealth to false did not solve this for me on 3.0.2 fwiw

[shlomi-noach]

Fix to be released in v3.0.3, later this week.

[shlomi-noach]

Fixed in https://github.com/github/orchestrator/releases/tag/v3.0.3