Attempt to perform PeerConnection operation when it is closed. about owt-client-native

[JamesTerm]

There is another way to reproduce this issue...

On the client native sample app:

1. Connect to 11
2. Set Remote to 12
3. Click the text button

Note: the stress here is that the caller is not connected, so I expect the message to return message failed.

4. Observe the message failed to send

On the caller side:

1. Login to 12
2. Set Remote ID to 11
3. Share Camera

I'd expect this to succeed, but instead it gives the same error message as before.

[RiuHDuo]

I met same problem when run windows p2p sample. How to fix this problem?

[JamesTerm]

I hope to hear some response on this... at the very least it should be flagged as p2p and bug. The key is peerconnectionchannel.cc: line 106 as a starting point. I have some other tasks that are on the front burner, but if this case is still open by then... I may take a look at how to solve it.

[JamesTerm]

Ok with today's epic merge of branch 76. (pr #216 ).. I will eventually come back to this issue as time allows and see if it is still present.

---

For now... I've worked around this problem by monitoring when the caller logs off. I found that OnServerDisconnected() is currently not used for p2p, so I'm using this as a gateway signal to the client code in order to keep changes in the sdk to a minimum. When the caller logs off, I then issue a reset to the app client code which spawns a DPC that disconnects, waits a second, and reconnects. (see initial entry about resetting the signaling_channel_ for that to work). I do not plan to submit these changes for pr as I feel it is a work-around solution, while mentioning this now to help others in the short term.

This solution is not perfect in that a caller may drop the call without logging off, in which case I can monitor the stream or provide a manual reset work-around, both of which do the same solution, but have their own triggering methods to get there.

[JamesTerm]

As an addendum to the last entry I've handled the stress of a caller dropping the call by use of GetConnectionStats()... loose polling this when the video feed is lost. This will let me know the moment the connection is lost.