Coder Social home page Coder Social logo

Comments (9)

joe-elliott avatar joe-elliott commented on June 28, 2024 1

Per discussions with Jaeger this functionality is being implemented in https://github.com/jaegertracing/jaeger-opentelemetry-collector and probably does not make sense to implement here as well.

@ledor473, I believe that once jaeger-opentelemetry-collector is up to date with master (for the sampling json) and they add the Kafka exporter this project will meet your needs.

cc @pavolloffay

from opentelemetry-collector-contrib.

yurishkuro avatar yurishkuro commented on June 28, 2024

What is the mechanism used to pull contrib code into the main binary?

from opentelemetry-collector-contrib.

tigrannajaryan avatar tigrannajaryan commented on June 28, 2024

What is the mechanism used to pull contrib code into the main binary?

@yurishkuro by adding a factory here: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/master/cmd/otelcontribcol/components.go

from opentelemetry-collector-contrib.

pavolloffay avatar pavolloffay commented on June 28, 2024

As an experiment, I have built https://github.com/jaegertracing/jaeger-opentelemetry-collector. At the moment it only includes Jaeger Elasticsearch exporter and the set of the default components. It might be easier to directly build the OTEL collector in the main Jaeger repository - it does not have to be hosted separately.

We should decide where Jaeger storage exporters will live. It depends if we want to add Jaeger specific functionality to the collector. For example one of the missing features is serving sampling strategies.

from opentelemetry-collector-contrib.

joe-elliott avatar joe-elliott commented on June 28, 2024

@pavolloffay
I am working on sampling strategies now to resolve this issue: open-telemetry/opentelemetry-collector#500

from opentelemetry-collector-contrib.

yurishkuro avatar yurishkuro commented on June 28, 2024

It might be easier to directly build the OTEL collector in the main Jaeger repository

+1

from opentelemetry-collector-contrib.

tigrannajaryan avatar tigrannajaryan commented on June 28, 2024

@yurishkuro @pavolloffay I am happy to see you are building on top of OpenTelemetry Collector. Do you mind sharing a bit more about what you plan to do? It would be great to know how the Collector is used by Jaeger.

from opentelemetry-collector-contrib.

pavolloffay avatar pavolloffay commented on June 28, 2024

+1 on what @joe-elliott said. I will just add that in Jaeger we are considering supporting OTEL proto as a first-class citizen. Therefore the contrib repository could provide kafka exporter and in the Jaeger collector there will be an importer for kafka in OT proto format.

from opentelemetry-collector-contrib.

tigrannajaryan avatar tigrannajaryan commented on June 28, 2024

Per discussions with Jaeger this functionality is being implemented in https://github.com/jaegertracing/jaeger-opentelemetry-collector and probably does not make sense to implement here as well.

Closing this issue as there is nothing else needed to be done in this repo.

from opentelemetry-collector-contrib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.