Questions about FSRSDataset about fsrs-rs

[L-M-Sherlock]

Yeah. We will pass an empty vec to dataloader_test. I haven't test that, so I passed full data to dataloader_test like the example provided in burn when developing. Please feel free to remove it.

[L-M-Sherlock]

Sorry, one more question: is config.seed supposed to be random in actual use (outside of tests)?

I recommend making it fixed. Because I don't want the user complain that the optimized parameters are always different over each training.

Is requestedRetention relevant for the training process, or something that only applies after the weights have been generated?

The requestedRetention is unrelated for the training. Users should set it by themselves.

[L-M-Sherlock]

Test dataset will be empty in real optimization for users. FSRS will all data in the training.

[dae]

Sorry, I may need an ELI5 here :-) Are you saying that when users train their real data, we'll pass in the full vec of FSRS items to dataloader_train, and an empty vec to dataloader_test? What advantages are there in passing in the full data to dataloader_test when developing?

[dae]

Sorry, one more question: is config.seed supposed to be random in actual use (outside of tests)?

[dae]

And one more :-) Is requestedRetention relevant for the training process, or something that only applies after the weights have been generated?