Comments (8)
We should use some of the code from: https://ariakit.org/examples/menu
It's already accessible and has the functionality we need.
Think we are using https://www.radix-ui.com/docs/primitives/components/dropdown-menu in hot :D
Sorry for the late message had a severe injury 😅
from app.
Think we are using https://www.radix-ui.com/docs/primitives/components/dropdown-menu in hot :D
Sorry for the late message had a severe injury sweat_smile
Yeah, we should probably use the component already in hot since we intend of building a design system across all the applications so we might as well borrow already built components from the other projects.
from app.
I comment on the wrong issues, but here is some context. #4 (comment)
We historically hide things that don't need to be in the header nav, i.e. "open an issue on github" link.
In the absence of a user profile, the dropdown should provide links specific to the user's experience.
- Logout is a minimum requirement
- I like having the report an issue link here.
- Perhaps we can link the changelog here too.
from app.
We have to define what's going to be under the Dropdown Menu... Is it only "Log out"? @chadstewart @bdougie
from app.
We have to define what's going to be under the Dropdown Menu... Is it only "Log out"? @chadstewart @bdougie
So right now, I think just having "log in" when there's no logged in user and "log out" when there's a logged in user present is good enough for now.
from app.
We should use some of the code from: https://ariakit.org/examples/menu
It's already accessible and has the functionality we need.
from app.
That's perfect!
from app.
🎉 This issue has been resolved in version 1.0.0 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀
from app.
Related Issues (20)
- Feature: add missing loading animations to page transitions HOT 5
- Feature: update create insight page repository recommendations to use the API HOT 2
- Test: update `OpenUserProfile` e2e test
- Bug: Duplicate Notifications for follows HOT 3
- Bug: User profile page throws Application error (cannot read property of undefined: reading map) HOT 7
- Bug: missing "Insights" header
- Feature: User searchbar HOT 5
- Bug: overlay of buttons on other items HOT 5
- Bug: Persistent Yellow Circle on Notification Bell After Viewing Notifications on OpenSauced HOT 3
- Feature: Allow users to post blogs from (RSS) multiple platforms HOT 12
- Feature: Remove title from highlights HOT 1
- Tracking: Lists Feature MVP
- Tracking: List feature creation flow MVP
- Refactor: Move explore tabs into dedicated pages
- List Creation Flow - Explore contributors page
- List Creation Flow - New List Page Layout HOT 1
- Feature: Add new layout for Lists pages
- Feature: Page Tabs for Insights/Lists Hub HOT 1
- Feature: new List Card component HOT 1
- Feature: New "List Name" header component HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from app.