Comments (3)
I think another con would be it would make type signatures really fiddly, and/or we'd lose a lot of type safety.
from spec.
We could allow the after hook to mutate the value but require that the type signature itself doesn't change.
from spec.
In addition to side-effects that don't impact the returned value at all (ending an OTel span, logging, etc), one of the use-cases we have for this is validation of a resolved flag value. However, that use-case is resolved simply by throwing in the after
hook if the retrieved value is invalid, which results in the evaluation defaulting, which is probably exactly what we'd want.
That is to say, I think we can, for now, close this since both those basic use-cases are satisfied. I don't think we need to support mutation of the after
value, for now. Please re-open if you disagree!
from spec.
Related Issues (20)
- Return value and `after` stage errors HOT 18
- Draft and merge client-side specification
- Perform vendor survey to better understand SDK paradigms HOT 1
- Dart/Flutter SDK HOT 11
- Spec styling and consistency issues
- [Question] `API.shutdown()` required in Go? HOT 5
- [Question] Static vs Dynamic context terminology HOT 1
- [bug] Multiple providers bound to one "name", and associated issues HOT 11
- Spec could be more clear about named-client/provider binding. Would "namespace" help? HOT 6
- Provider Initialization Fallback HOT 4
- Consider 0.7.0 release HOT 1
- Specify provider state after `shutdown()` HOT 8
- [Static-context Paradigm] How to handle errors in `on context changed` HOT 2
- Any plans to create feature flag code management project? HOT 5
- Manage context per named provider when using the static-context paradigm HOT 1
- Set context during provider registration when using the static-context paradigm HOT 3
- Redefine named clients as domain
- Clarification of reason for evaluation detail and evaluation. HOT 2
- DOC:Best practices or Cases HOT 10
- Proposal to move `Provider Status` field from provider to SDK, refine semantics around ContextChange events HOT 22
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spec.