Comments (3)
Here now!!!
from pimg.
hello,
we want to deprecate placeholder to use array of imagePlaceholder and image right?
Thanks in advance.
from pimg.
- Deprecating placeholder will still allow the use of placeholder but will warn if used, to be deprecated in the next major version.
- Src attribute will take an array of images or a string. The things to check for:
- One will have to check for the
typeof
src - If src is a string, we just assume the user doesn't want to pass a placeholder, and just renders the image although if it's a cloudinary image, we'll still lazy load it.
- If an array is passed to src, and the length is not 2, warn about not passing the right set of props.
- We'll still render the same placeholder for different srcset(s) as the placeholder is blurry. I might be the one to implement this tho.
- One will have to check for the
RFC
Normally, I would have said we should distinguish placeholders and the real images with a comma(,) as done is srcset. Just thought about the way it might look like if we decided to leave it that way. But, if done with arrays, it can easily extend to the next line with prettier.
from pimg.
Related Issues (20)
- Allow custom `loading` className HOT 2
- Test Preact and Vue Components HOT 1
- Create better docs and examples
- Setup Eslint and Prettier
- Add Waypoint HOT 3
- Expose a singleton to save configs HOT 1
- Should we deprecate the thumbnail component? HOT 1
- Goodbye scrollToReveal, Welcome fetchOnDemand HOT 1
- goodbye thumbnail, welcome placeholder
- Replace Global Configs with Providers HOT 2
- Size is not 20 bytes HOT 1
- Deal with service workers HOT 3
- Pre v2: Fix vulnerabilities HOT 4
- tried to set the project up on my windows 10 HOT 18
- Add alt support. HOT 2
- Use lerna to manage multiple packages HOT 4
- Add polyfill for IntersectionObserver API
- Introducing plugins
- Demo - Missing HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pimg.