Coder Social home page Coder Social logo

Comments (3)

msbarry avatar msbarry commented on May 19, 2024

Thanks @caspg, it looks like this is one of the ways you are talking about that exists in both relations: https://www.openstreetmap.org/way/536642248

I'm a little confused how openmaptiles is choosing S7 for the transportation name ref value since this logic appears to just take the ref value from route_1 if it's a valid route network?

https://github.com/openmaptiles/openmaptiles/blob/8693822d506076d1cbf0d777d40d3a0a12986ce6/layers/transportation_name/update_transportation_name.sql#L299-L303

from planetiler.

ZeLonewolf avatar ZeLonewolf commented on May 19, 2024

Huh, I'm surprised it works that way and I wrote the route_N functionality in OpenMapTiles. If anything, I would say the planetiler output is the intended implementation and openmaptiles has a bug 🤔

from planetiler.

msbarry avatar msbarry commented on May 19, 2024

I think route_n is right but omt has logic to use refs preferring:

  1. Major networks the way is a part of
  2. Ref tag on the way

Planetiler was using the ref from any network the way was a part of instead of the ref on the way. I changed it to match omt's behavior, and added an optional flag to fall back to the ref from any relation if 1 and 2 are missing.

Sounds like there may need to be some more complex handling in openmaptiles for this network type?

from planetiler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.