Allow configuration of the limiter maximum in ResqueCleaner::Server about resque-cleaner

[ono]

I actually expected to get a request like this. The reason I just hardcoded 1000 for the initial value is not special. I just followed YAGNI principle: just waiting for someone like you who is really necessary to improve this since the current implementation works well to me and project I am involving.

So how do you want to do this? There are some approaches I can think of:

• Change the default value to the higher value e.g. 5,000
• Make the limiter value configurable e.g. environment variable or configuration file
• Configurable on web interface

I actually don't have a good idea for the third one which provides the functionality 1. simply, 2. clear to someone new to resque-cleaner, 3. avoid a danger which a team staff set very high value without knowing the risk. Do you have any good idea?

I give my vote to environment variable.

[shayfrendt]

@ono I'm down with YAGNI. It stands for You Are Gonna Need It, right? ;-)

My vote is setting up a configuration class - something like:

• https://github.com/airbrake/airbrake/blob/master/lib/airbrake/configuration.rb

I feel like in the ruby community, a config block is probably more conventional then relying on/setting an environment variable (in an initializer, in the case of Rails applications).

I agree with your point about not allowing setting the limit on the web interface, especially if there are performance implications.

Whatchu think?

[ono]

Thanks for your suggestion.

I think that resque-cleaner better follow Resque way if possible. I will also have a research how other popular resque plugins provide configuration and try to find a good way.

[beerlington]

+1 for using a configuration class or something that can be done in code rather than setting an environmental variable.

[ono]

Sorry for the delay. I've just pushed my change to master and released version 0.2.9.

https://github.com/ono/resque-cleaner#configuration

Thanks!

[shayfrendt]

@ono Awesome - thanks!!