Coder Social home page Coder Social logo

The name of ONNF is misleading about onnx-mlir HOT 11 CLOSED

onnx avatar onnx commented on September 28, 2024 1
The name of ONNF is misleading

from onnx-mlir.

Comments (11)

doru1004 avatar doru1004 commented on September 28, 2024 1

Fixed by #32

from onnx-mlir.

tjingrant avatar tjingrant commented on September 28, 2024

If we go with the onnx-mlir branding, will it resolve your concern? It'd be a bit simpler.

from onnx-mlir.

caoimhinuibrian avatar caoimhinuibrian commented on September 28, 2024

from onnx-mlir.

tjingrant avatar tjingrant commented on September 28, 2024

Sounds good, will switch to onnx-mlir throughout our codebase.
@linkerzhang please let me know your thought!

from onnx-mlir.

linkerzhang avatar linkerzhang commented on September 28, 2024

Thanks! onnx-mlir is better than onnf :), though I'll be open to other even more descriptive names if any (I'm not good at naming at all, btw.).

from onnx-mlir.

bhack avatar bhack commented on September 28, 2024

As the ONNX dialect is a quite different third party dialect cause It is related to a standard do you plan to contribute It in https://github.com/llvm/llvm-project/tree/master/mlir/lib/Dialect?

from onnx-mlir.

bhack avatar bhack commented on September 28, 2024

There is just a new doc if you are interested https://github.com/llvm/llvm-project/blob/master/mlir/docs/CreatingADialect.md

from onnx-mlir.

tjingrant avatar tjingrant commented on September 28, 2024

It is one of our goals to try and see if there is a place for ONNX to exist within MLIR core. But it seems like we have some distance to cover and more work/discussions are needed before we can tell whether MLIR core is the right place for ONNX dialect and whether the MLIR community is willing to accept the ONNX dialect - c.f. https://groups.google.com/a/tensorflow.org/forum/#!msg/mlir/CUL3_8fnJb4/0Uvt3M-FAQAJ.

from onnx-mlir.

bhack avatar bhack commented on September 28, 2024

Yes but the MLIR community position was a little bit evolved from the google group post.
I.e. See https://llvm.discourse.group/t/development-of-high-level-tensor-compute-primitives-dialect-s-and-transformations/388/57

from onnx-mlir.

AlexandreEichenberger avatar AlexandreEichenberger commented on September 28, 2024

from onnx-mlir.

bhack avatar bhack commented on September 28, 2024

Ok but try to early interact with them on discuss/Discord.

from onnx-mlir.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.