Comments (5)
The same is with empty bool query, empty filtered query and other queries that behaviour is defined through setters (not constructor).
At this moment elasticsearch itself throws quite readable error in such cases (of course with all query dumped in the error).
It is open for discussion if ElasticsearchDSL should validate these queries.
from elasticsearchdsl.
I think that it could be too much effort to maintain all possible cases when this could happen.
from elasticsearchdsl.
@saimaz, @mvar what's your opinion?
from elasticsearchdsl.
That would be a massive responsibility to validate whole queries. We cannot validate one scenario, so it's all or none. The exception in query if there is no function set coud be a solution for better error handling, but as I said previosly, query validation we should take very carefully.
from elasticsearchdsl.
After long discussions and investigation. We believe that query structure validation is currently not a DSL responsibility. We simply providing a way to generate an array in objective perspective by asuming the user knows what he is writing.
Query validation should be performed in the native client as lowest part in the chain.
from elasticsearchdsl.
Related Issues (20)
- doc page link 404 HOT 1
- Implement GeoDistanceSort
- How do you do this sort HOT 2
- Is this project alive? HOT 8
- HTTP 500 Internal Server Error Class \Document\PostDoc does not exist
- Support Symfony 4.4 HOT 1
- How to build this query ?
- It is not possible to set field at function_score random_score
- DateHistogramAggregation does not support TimeZone HOT 2
- PHP 8 support HOT 7
- DateHistogramAggregation does not support 'timezone' ?
- Missing weight parameter in function score query for certain functions
- Same configuration returned different hits HOT 1
- php 8 support HOT 1
- Add new tag v6.2.1 with renaming of MaxAggregation.php class
- Elasticsearch 8.0 removed support for `interval` in `date_histogram` aggregation types HOT 2
- Lack of symfony/serializer 6 support HOT 1
- php 8.1 support HOT 3
- Elasticsearch 8 support HOT 1
- Compatibility issue with Laravel 10 and symfony/mime in ongr/elasticsearch-dsl v7.2.2 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elasticsearchdsl.