Coder Social home page Coder Social logo

Comments (7)

oorlov avatar oorlov commented on September 24, 2024

Nice to hear it!
We already found issue with moreSubSkus a day ago and going to fix.
Very interesting with security. Will update it together with #35
Will revise issue with 20 items.
Very useful notice, thank you!

from openiab.

markostamcar avatar markostamcar commented on September 24, 2024

Great :)

from openiab.

markostamcar avatar markostamcar commented on September 24, 2024

Hello! Good job. Just wanted to let you know Google produced a new NPE with their security fix which happens on devices without Google Play. queryIntentServices() can return null in that case. See here:
https://code.google.com/p/marketbilling/issues/detail?id=149

But in our code I opted for a shorter solution:

if (mContext.getPackageManager().queryIntentServices(serviceIntent, 0) != null
&& !mContext.getPackageManager().queryIntentServices(serviceIntent, 0).isEmpty()) {

from openiab.

oorlov avatar oorlov commented on September 24, 2024

Size of batch can be changed in IabHelper.QUERY_SKU_DETAILS_BATCH_SIZE

from openiab.

oorlov avatar oorlov commented on September 24, 2024

About NPE:
it's strange that queryIntentServices() returns null. There is no notes about it in javadoc, so who does expect it there? I guess it is a bug in Kindle Fire.
In OpenIAB it shouldn't appear because IabHelper code is not used on Amazon device. GooglePlay.isPackageInstaller() returns false there.

from openiab.

oorlov avatar oorlov commented on September 24, 2024

any other problems here?

from openiab.

markostamcar avatar markostamcar commented on September 24, 2024

Nope, that's it from me :) Regarding the NPE, I think it also happens in the Android emulator.

from openiab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.