Coder Social home page Coder Social logo

Comments (6)

md5 avatar md5 commented on June 11, 2024

@pravi Regarding the "request to follow", do you think that omniauth-saml hasn't followed SemVer for the most recent release?

from omniauth-saml.

pravi avatar pravi commented on June 11, 2024

@md5 I maintain gitlab package in debian. Gitlab wants omniauth-saml ~> 1.4.0 and that will break if I upload omniauth-saml 1.5.0. If gitlab is confident 1.5 will not break their code, they can confidently declare omniauth-saml ~> 1.4. But as things stand right now, there is no clear statement. Do you think its realistic for gitlab to check over 260 gems how each of their previous releases were? SemVer makes life easy for users of libraries and I think every library should follow it and make it easy for people to find that information.

from omniauth-saml.

suprnova32 avatar suprnova32 commented on June 11, 2024

@pravi what version of GitLab are you packaging? omniauth-saml was updated to 1.4.2 on version 8.4.4 and GitLab version 8.6 will make use of omniauth-saml 1.5.0.

You can see the commit for 1.4.2 here: gitlabhq/gitlabhq@ea7bdc7

and the commit 1.5.0 here: gitlabhq/gitlabhq@32ddf09

Please let us know where you think omniauth-saml has not followed the SemVer rules you mention.

from omniauth-saml.

bufferoverflow avatar bufferoverflow commented on June 11, 2024

I guess the thing @pravi likes to have is a clear commitment to semver principle and I agree with him we should mention this within the README.md to simplify life of software packagers and users.

I prepare a pull request for this.

from omniauth-saml.

suprnova32 avatar suprnova32 commented on June 11, 2024

if all it takes is a simple mention of commitment, then sure, let's commit.

from omniauth-saml.

pravi avatar pravi commented on June 11, 2024

Yes, a mention of commitment is all I need.

from omniauth-saml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.