Coder Social home page Coder Social logo

render being called twice about om HOT 5 CLOSED

omcljs avatar omcljs commented on July 17, 2024
render being called twice

from om.

Comments (5)

swannodette avatar swannodette commented on July 17, 2024

pending state is indeed merged in after will-mount. Do you have minimal example where you aren't seeing this? Thanks.

from om.

colinkahn avatar colinkahn commented on July 17, 2024

Of course. Here's a gist with a simple app based mostly on what you had done in the todo app.

https://gist.github.com/colinkahn/8338003

You can see that the app-state has :projects, and there's one default project populated in there. This project ends up being created on the first render pass, but at that point render shows comm as nil. This results in an the error Uncaught Error: No protocol method WritePort.put! defined for type null: when you try to delete the default project. Then render gets triggered again, gets comm from owner, so projects created later are fine and can be deleted as expected.

Logging out everything will-mount is called first, then the first render, but w/ comm nil, then render is called again with comm being the async channel.

from om.

swannodette avatar swannodette commented on July 17, 2024

Thanks for the minimal example, will look into it.

from om.

swannodette avatar swannodette commented on July 17, 2024

I cannot replicate this using master. I see a value printed out on both renders, what version of Om are you using? Render being called twice is not a very serious issue, we can optimize this at some point in the future.

from om.

colinkahn avatar colinkahn commented on July 17, 2024

Looks like this was due to me not using the latest version of ClojureScript, sorry about that. Thanks for looking into it anyways.

from om.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.