Coder Social home page Coder Social logo

Comments (3)

swannodette avatar swannodette commented on July 17, 2024

The point about IEquiv over identical? in shouldComponentUpdate is solid and one I've been pondering myself for a while. I'm not sure that something like om.core/join is problematic, in anycase it's orthogonal to benefits delivered by relying on IEquiv. I will think about it some more.

from om.

swannodette avatar swannodette commented on July 17, 2024

shouldComponentUpdate fixed to use not= in master, ed99bf2. If you think about the use case where the application state is laid out more like a database and not like a UI tree I think you'll see that om.core/join or something like it is really not such a bad idea. Thanks for the feedback.

from om.

swannodette avatar swannodette commented on July 17, 2024

Just to keep this up-to-date. I've reverted the IEquiv change in master. Relying on IEquiv is currently problematic since you can nest Om components that use the exact same piece of data. If you call om.core/set-state! further down then we can not determine the invalidated path.

I think I realized this at some point and that's why we weren't using IEquiv.

from om.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.