Externalize hardcoded strings into the strings.xml file about hatholy

[OmarShafei-coder]

Thanks for your time, Really appreciate it. I will use Arabic only in the app, but if you know other purposes to do that please let me know.

…

On Tue, 13 Oct 2020, 10:38 pm ahmednabil88, ***@***.***> wrote: Try to externalize hardcoded strings like the below one into the strings.xml file https://github.com/OmarShafei-coder/Hatholy/blob/e59c0f7b894e28036928de6ea7a790ae622b09d7/app/src/main/java/com/omarshafei/hatholy/ui/AddPost/AddPostFragment.java#L147 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJR42YJYLGLAMNOUTML5GVTSKS3FFANCNFSM4SPUIHJA> .

[ahmed-nabil-elagder]

Greate Omar, I will list to you why externalize hardcoded strings (whatever the language you will use) is a good practice however if your application will support one language (Arabic in our case).

• In case of one string is used in multiple locations, the current behavior, you will take a cycle to update all, but if your externalize it, you will update it once in one place.
• It will help you to apply (Separation of concerns) principle, which keeps your later modification safe (not update the main classes when you will just need to update strings values).

Good luck Omar!

[OmarShafei-coder]

Thanks so much for your time. I get it.

…

On Wed, 14 Oct 2020, 1:42 pm ahmednabil88, ***@***.***> wrote: Greate Omar, I will list to you why *externalize hardcoded strings* (*whatever the language you will use*) is a good practice however if your application will support one language (Arabic in our case). - In case of one string is used in multiple locations, the current behavior, you will take a cycle to update all, but if your externalize it, you will update it once in one place. - It will help you to apply (Separation of concerns) principle, which keeps your later modification safe (not update the main classes when you will just need to update strings values). Good luck Omar! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJR42YPOMOOLH5S324KF6JDSKWFB7ANCNFSM4SPUIHJA> .

[OmarShafei-coder]

Done bro with help of @hamza94max