Coder Social home page Coder Social logo

Comments (5)

omab avatar omab commented on August 17, 2024

@RonnyPfannschmidt, at first glance it doesn't, but that's what allows you to do from social.apps.flask_app.models import UserSocialAuth in your project (after init_social() was called of course).

from python-social-auth.

RonnyPfannschmidt avatar RonnyPfannschmidt commented on August 17, 2024

but that is an project-specific object - that will get stored inside the project if used proper, why have such an hack in addition

from python-social-auth.

omab avatar omab commented on August 17, 2024

@RonnyPfannschmidt, FlaskStorage is needed to be on some import path since it's used by the strategy, you can see how the default value is used https://github.com/omab/python-social-auth/blob/master/social/apps/flask_app/utils.py#L10, there's no need to have the others classes since they are accessible through FlaskStorage, I'm willing to remove those from globals().

I'm not comfortable with this solution, having that init_social() looks awful IMO and I really like to get rid of that.

from python-social-auth.

RonnyPfannschmidt avatar RonnyPfannschmidt commented on August 17, 2024

if you have a function that takes the app anyway, it can just do a setdefault on the app with the real objects, no need for the funky default schemes

from python-social-auth.

omab avatar omab commented on August 17, 2024

Code was improved, seems that this can be closed now.

from python-social-auth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.