[Bug] Double click in FxFileChooserDialog does not return selected file about fxfilechooser

[Oliver-Loeffler]

Thanks for reporting this! Well, I will try to reproduce the issue and see that there will be a fix.

[Oliver-Loeffler]

Please try out the branch issue-44. It is quite a hack as the controller now also has a reference to the dialog.
In general, a rethinking of the current structure is needed.
But, if this works for you, I'd release it as 0.0.7 to Maven Central.

I was testing it manually with net.raumzeitfalle.fx.demos.DemoJavaFxDialog.java.

Beside the double click issue, the dark mode in the Dialog is not working properly - need to put some work in there as well.

[Oliver-Loeffler]

Hi,
so there is now a new version 0.0.7, just uploaded it. It contains the fix for the broken double click in the Dialog. The fix for the broken dark mode will then become part of 0.0.8 or later. This change comprises the internal API, hence going with 0.0.7 should be okay.

<dependency>
   <groupId>net.raumzeitfalle.fx</groupId>
   <artifactId>filechooser</artifactId>
   <version>0.0.7</version>
</dependency>

or

implementation 'net.raumzeitfalle.fx:filechooser:0.0.7'

Thanks for sharing your setup details - so I will get this project into a little better shape and ready for Java11 soon, there will be also a module-info then but this is not a mandatory requirement. There will be a solution for darkmode in Dialog within a few days,

The stage version It works as a drop-in, looks a little different. Well, there is the directory chooser, which is in a quite early stage. It should then also be suitable for huge directory trees.

For development on this I am currently using the Azul Java 8 JDK, zulu where JavaFX is included. Think Azul also offers Java-11 and Java-17 with FX included. This is quite convenient for development.

[Oliver-Loeffler]

The dark mode inside Dialog is now working again. Also the resize behavior improved for the dialog as the minimum size is now properly constrained. There will be a 0.0.8 release tomorrow bringing the improvements.

[Oliver-Loeffler]

@ArchibaldBienetre The new version 0.0.8 is now available. Its been tested on MacOS and Windows 10, works for both. Would be glad if you could share if it eventually works as intended on Ubuntu!

[ArchibaldBienetre]

Thanks for checking in!

I've been using the 0.0.8 since this afternoon, the update introduced no serious problems (just the default skin, I had to change that to MODENA now), my integration tests (testfx) still work as before. ✔️

Manual test works, dark layout too.

My project uses FXFileChooserStage now, but I'll take the Dialog implementation for another spin 🔍

EDIT: Dialog implementation is still (i.e., like the 0.0.7) working like a charm ✔️

[Oliver-Loeffler]

Well yes. I can reproduce this. And you are right, the result converter is not triggered on double click. I need to look into the dialog API to understand how to call this. Very good, thanks for pointing this out.

Nevertheless, I was planning to completely remove the Dialog part. Do you actually prefer the Dialog version over the Stage version?

[ArchibaldBienetre]

Do you actually prefer the Dialog version over the Stage version?

You mean, this? https://github.com/Oliver-Loeffler/FXFileChooser#a-version-with-a-completely-customizable-stage
I have not given it a try, yet.
I was glad to get something to work with TestFX ':D

I can have a look.

[Oliver-Loeffler]

Yes this one. Was playing with both approaches, using a modal stage vs. using a JavaFX dialog. Nevertheless, this project deserves some more love over next time. It should now work with the modal Stage and the dialog,

TestFX is awesome - but I think it needs more people working on it. It is really underrated and underappreciated.

Btw, which Java version are you using? Would this be still useful to you if the project would move to Java 11?

[ArchibaldBienetre]

...
I was testing it manually with net.raumzeitfalle.fx.demos.DemoJavaFxDialog.java.

Beside the double click issue, the dark mode in the Dialog is not working properly - need to put some work in there as well.

I can confirm both

• it's working in the demo with the doubleclick
• the dark layout demo is broken :(

It was a bit of a struggle to make it work. I installed JDK 8 as that is the target version, and then some dependencies were still missing (Java 8 does not support modules yet, I'd rule out those):

Index: pom.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/pom.xml b/pom.xml
--- a/pom.xml	(revision 437f9a90fbd3fa8f46898ae0348e9e296baa12c5)
+++ b/pom.xml	(date 1639946873593)
@@ -19,6 +19,7 @@
 		<junit.platform.version>1.7.1</junit.platform.version>
 		<junit.jupiter.version>5.7.1</junit.jupiter.version>
 		<awaitility.version>4.0.3</awaitility.version>
+		<javaFx.version>18-ea+8</javaFx.version>
 
 		<testfx.version>4.0.6-alpha</testfx.version>
 		<testfx.monocle.version>8u76-b04</testfx.monocle.version> <!-- jdk-9+181 for Java 9 -->
@@ -241,6 +242,31 @@
 	</build>
 
 	<dependencies>
+		<dependency>
+			<groupId>org.openjfx</groupId>
+			<artifactId>javafx-base</artifactId>
+			<version>${javaFx.version}</version>
+		</dependency>
+		<dependency>
+			<groupId>org.openjfx</groupId>
+			<artifactId>javafx-controls</artifactId>
+			<version>${javaFx.version}</version>
+		</dependency>
+		<dependency>
+			<groupId>org.openjfx</groupId>
+			<artifactId>javafx-fxml</artifactId>
+			<version>${javaFx.version}</version>
+		</dependency>
+		<dependency>
+			<groupId>org.openjfx</groupId>
+			<artifactId>javafx-graphics</artifactId>
+			<version>${javaFx.version}</version>
+		</dependency>
+		<dependency>
+			<groupId>org.openjfx</groupId>
+			<artifactId>javafx-swing</artifactId>
+			<version>${javaFx.version}</version>
+		</dependency>
 		<dependency>
 			<groupId>org.awaitility</groupId>
 			<artifactId>awaitility</artifactId>

Thank you for putting in your time, I'd be superglad for a 0.0.7 alpha that I could use without the workaround :) .

[ArchibaldBienetre]

Do you actually prefer the Dialog version over the Stage version?

You mean, this? https://github.com/Oliver-Loeffler/FXFileChooser#a-version-with-a-completely-customizable-stage I have not given it a try, yet. I was glad to get something to work with TestFX ':D

I can have a look.

Nice, it seems I can just use it as a drop-in replacement, that's fine then.

[Oliver-Loeffler]

Kudos for your work-around!

[Oliver-Loeffler]

Dark mode and resizing are now properly working with version 0.0.8. Closed with 5e27cb4 and bebd9dd.

New version is available at Maven Central.

<dependency>
   <groupId>net.raumzeitfalle.fx</groupId>
   <artifactId>filechooser</artifactId>
   <version>0.0.8</version>
</dependency>