Comments (8)
Yeah, I can confirm it works after the update. Great work, thanks! 👍
from analytics.
Thanks for logging and researching this issue, @derwaldgeist! Noted.
from analytics.
@derwaldgeist v3.0.5
is published 🎉 . I have tested locally with the Flow Router example and all seems good! 😄 Let me know how the latest release goes for you!
Going to mark this issue as resolved, but please open back up if you have any issues. 👍
from analytics.
@derwaldgeist Thanks for adding this issue. Could you update the issue title to mention FlowRouter as this bug is specific to FlowRouter. I am also curious to know which versions of this package and flow router you are using. Is their any version changes in these two pkgs when you upgrade to Meteor 1.6.
Also the code related to this is located over in our auto-analytics package. Previously have had other issues relating to flow-router and this integration due to the way it handles history state.
I also suspect that it's not the monkey patch but logPageFirstLoad where we use window.history.replaceSate
I am guessing this is why path
disappears from the state object.
from analytics.
A fix has been created for the above bug and a PR has been opened on our auto-analytics pkg.
We will publish a new meteor analytics package once @okgrow/[email protected]
is released.
For further details you can read this comment here.
from analytics.
Thanks again for the very fast fix! Changed the title so it reflects FlowRouter.
from analytics.
Shall I close this issue or do you want to keep it open until the update has been published?
from analytics.
@derwaldgeist No problems. Lets keep this open until we publish the fix. As I am waiting for a code review on the original PR & will then need to make a new release for meteor analytics once the npm pkg has been published.
from analytics.
Related Issues (20)
- Is there a way of disabling automatic identification? HOT 3
- No data sent to Google Analytics HOT 1
- Does this work with React Router v4? HOT 3
- Basic Google Analytics setup does not seem to work HOT 6
- Custom Event Tracking HOT 6
- Update analytics.js HOT 3
- Mixpanel integration not reporting on a specific project HOT 6
- TypeError: Cannot read property '0' of undefined after update to version 3.0.2 HOT 5
- 3.0.2 break meteor HOT 3
- App crashes with ad blocker HOT 2
- Multiple Google Analytics tags detected [solved] HOT 2
- net::ERR_BLOCKED_BY_CLIENT with Ad blocker in production (Mixpanel) HOT 2
- Package breaks whole page when adblock is enabled HOT 1
- GDPR compliance for Google Analytics HOT 4
- Tag not found HOT 1
- SegmentIO is not loaded properly, so events are not passed to destinations. HOT 1
- How to supply our own analytics.js build? HOT 1
- Setting People Properties and Incrementing Events for Mixpanel HOT 4
- Google Tag Manager integration not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from analytics.