reserved identifier violation about ncurses-st-menu

[okbob]

This name is based on conventions used by ncurses library. So maybe is not correct against SEI CERT C Coding Standard, but it is ok (for me) because use same conventions like library that should to enhance.

[elfring]

How do you think about to avoid that this software depends on undefined behaviour?

[okbob]

pá 13. 9. 2019 v 7:53 odesílatel Markus Elfring <[email protected]> napsal:

How do you think about to avoid that this software depends on undefined behaviour <https://www.securecoding.cert.org/confluence/display/c/CC.+Undefined+Behavior#CC.UndefinedBehavior-ub_106> ?

use common sense, please. The same naming convention is used in ncurses - https://en.wikipedia.org/wiki/Ncurses Sometimes you should to choose between two conventions. But use any naming convention cannot to break anything. —

…

You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1?email_source=notifications&email_token=AAEFO42EF6VEJLF7KBXRJPTQJMTGFA5CNFSM4IWMHHOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6UBDSI#issuecomment-531108297>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEFO4ZEYQVZY5NMEVMRXHLQJMTGFANCNFSM4IWMHHOA> .

[okbob]

How do you think about to avoid that this software depends on undefined behaviour?

I rechecked it - and this name is absolutely correct - this is a false alarm

[elfring]

More software components were published which are still standard incompliant.

[okbob]

pá 13. 9. 2019 v 8:06 odesílatel Markus Elfring <[email protected]> napsal:

More software components were published which are still standard incompliant.

For me, in this, area only ANSI C is a standard. https://en.wikipedia.org/wiki/ANSI_C . Others are recommendations. And when you will write a library, the library should be consistent in environment where it is used. So I wrote a library based on ncurses and it is consistent with ncurses.

…

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1?email_source=notifications&email_token=AAEFO47FWZVMC7DYAIJ3U2DQJMUWZA5CNFSM4IWMHHOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6UBX6I#issuecomment-531110905>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEFO424ZSFMBMQ2DCTK2YLQJMUWZANCNFSM4IWMHHOA> .

[elfring]

I find standard compliance more important for source files of the involved programming languages than a questionable consistency.

[okbob]

I don't think so I break any rules when I use _ST_XXXX as identifier inside library. Can be different, if I used it in application.

[elfring]

I don't think so I break any rules when I use _ST_XXXX as identifier inside library.

• Does this identifier belong to the implementation of a compiler for the programming language “C” (or “C++”)?
• Do you care for achieving more defined software behaviour?

[okbob]

pá 13. 9. 2019 v 9:00 odesílatel Markus Elfring <[email protected]> napsal:

…

I don't think so I break any rules when I use _ST_XXXX as identifier inside library. - Does this identifier belong to the implementation of a compiler for the programming language “C” (or “C++”)? probably not - because compilers uses double _ .. __ - Do you care for achieving more defined software behaviour? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1?email_source=notifications&email_token=AAEFO4ZLDMSTLZ4RZGMDHW3QJM3CPA5CNFSM4IWMHHOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6UEY7Y#issuecomment-531123327>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEFO4Y7FKJRGLJLA5YBESTQJM3CPANCNFSM4IWMHHOA> .

[elfring]

I suggest to reduce the tampering with the reserved name space also for your software.

[okbob]

fixed by latest commit

[elfring]

Thanks for your small source code improvement.