Fail in test potentially due to Irish Rail API Change about ierail

[oisin]

They have changed the serialization of direction in the JSON. It used to be Southbound or Northbound, now it's To Greystones, To Howth and such.

[gary-rafferty]

XML response has changed slightly it, which is borking our 'northbound_from' and 'southbound_from' calls. We used to select based on the direction attribute, which used to be "Northbound" or "Southbound".

[gary-rafferty]

Ah, beat me to it 😆

[oisin]

We have to update those methods, but there's more to it -- this just harmonizes the special approach that was for DARTS with the other trains. Perhaps throw a not a DART exception if the target train is a mainline :)

[gary-rafferty]

👍 I was just thinking something similar. Was their docs page always that rough?

[oisin]

Yeah, has always been rough. If the train is a DART we'll probably need to keep a N-S list of stations, so we can keep these APIs functional.

[oisin]

It switched back to this To X format again just there. Waiting for a bit to see if it changes back again just like it did last time :)

[oisin]

...and it's back to normal.

[oisin]

Closing this due to lack of activity tbh.