Comments (8)
That's a reasonable request. I'll make the change.
from agoo.
Please try the "mime-txt-utf8" branch.
from agoo.
I took a peek at changes and I spotted the .rb
file ending which I imagine should default to utf8 too, but this suits my needs as is. Every ruby source file I work on is in utf8 at least. 🤷
from agoo.
I think for Ruby files the receiver decides although for display it might make sense. I was hesitant to get too carried away and cause issue by over specifying. Ruby is probably safe though. Can you try a ruby file and see how the browser handles it?
from agoo.
Firefox seems to not handle .rb with emojies without the charset:
# hax.rb
puts "get hacked! >:D"
puts "emojiii: 🚀🚀🚀"
I can appreciate you wanting to be careful, so I took a look at what github does when you request an .rb file:
I don't know if you happen to have any .rb files with emoji in them 😅
I think the absolute safest thing to do here would be to run charset detection on the file before deciding what to put in the header, and defaulting to utf8 since it is so ubiquitous and backwards compatible with ascii.
This kind of detection is probably overkill though.
from agoo.
The issue isn't emoji but other unicode characters for languages such as Japanese. I'll add to Ruby and other language files on the list.
from agoo.
Pushed the changes for the other text file types.
from agoo.
Released
from agoo.
Related Issues (20)
- Fragment usage HOT 17
- CORS issues HOT 8
- Agoo dumps core on malformed SDL HOT 5
- fails to launch in clustered mode HOT 17
- Agoo Fragment Cycle Security Vulnerability HOT 2
- Disabling introspection for GraphQL HOT 12
- Changes on args or req does not get fowarded to the other calls HOT 9
- Static asset with space in filename HOT 4
- gem install agoo fails on MacOS Ventura 13.2.1 HOT 9
- Agoo crash and exit HOT 7
- CLI options for SSL/TLS HOT 3
- localhost is crashing as bind address HOT 4
- 502 via nginx proxy_pass HOT 3
- TypeError: no implicit conversion of Array into String HOT 2
- rackup -r agoo -s agoo Doesn't Work HOT 8
- Out of curiousity would anything have been lost or gained by using ABI, or FFI, or *.SO over the current API method of directly calling in the Ruby C file headers? HOT 3
- root == '' gives access to the whole filesystem HOT 15
- Port cleanup on shutdown? HOT 3
- REMOTE_ADDR not set on ENV HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from agoo.