Coder Social home page Coder Social logo

Comments (8)

ohler55 avatar ohler55 commented on June 4, 2024

That's a reasonable request. I'll make the change.

from agoo.

ohler55 avatar ohler55 commented on June 4, 2024

Please try the "mime-txt-utf8" branch.

from agoo.

odinhb avatar odinhb commented on June 4, 2024

image

I took a peek at changes and I spotted the .rb file ending which I imagine should default to utf8 too, but this suits my needs as is. Every ruby source file I work on is in utf8 at least. 🤷

from agoo.

ohler55 avatar ohler55 commented on June 4, 2024

I think for Ruby files the receiver decides although for display it might make sense. I was hesitant to get too carried away and cause issue by over specifying. Ruby is probably safe though. Can you try a ruby file and see how the browser handles it?

from agoo.

odinhb avatar odinhb commented on June 4, 2024

Firefox seems to not handle .rb with emojies without the charset:

# hax.rb
puts "get hacked! >:D"

puts "emojiii: 🚀🚀🚀"

image

I can appreciate you wanting to be careful, so I took a look at what github does when you request an .rb file:
image
image

I don't know if you happen to have any .rb files with emoji in them 😅

I think the absolute safest thing to do here would be to run charset detection on the file before deciding what to put in the header, and defaulting to utf8 since it is so ubiquitous and backwards compatible with ascii.

This kind of detection is probably overkill though.

from agoo.

ohler55 avatar ohler55 commented on June 4, 2024

The issue isn't emoji but other unicode characters for languages such as Japanese. I'll add to Ruby and other language files on the list.

from agoo.

ohler55 avatar ohler55 commented on June 4, 2024

Pushed the changes for the other text file types.

from agoo.

ohler55 avatar ohler55 commented on June 4, 2024

Released

from agoo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.