Is there Capr support for Health Economics Data Tables about capr

[mdlavallee92]

Correct I haven't added payer plan period as a domain as it is not something that I actively use. Going to close this issue for now but if you feel like you are up to making the PR you can always link it back to this issue. If you want to make a pull request and add this feature @pa-nathaniel you can follow the basic steps here (adapted from github templates):

1. Fork and clone the repository.
2. Build the package locally using devtools or the build tab in Rstudio
3. Run the check in the build tab to make sure there are no errors
4. Create a new branch: git checkout -b my-branch-name.
5. Make your change, add unit tests, and make sure the tests still pass.
6. Push to your fork and submit a pull request target the develop branch.
7. Wait for your pull request to be reviewed and merged.

Here are a few things you can do that will increase the likelihood of your pull request being accepted:

• Follow the hades style guide. Note that there is a preference in HADES towards camelCase as opposed to snake_case. Probably the biggest difference to the the tidyverse style guide which is also a helpful guide.
• Write and update tests.
• Keep your changes as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests.
• Write a good commit message.

I should probably add contributor guidelines and a code of conduct lol

[ablack3]

Hi @pa-nathaniel, good question.

Capr's domain support exactly matches what is available in Atlas and Circe so you should be able to use the following attributes. But this has not been implemented in Capr yet. Shouldn't be too hard to add but it might still be a while before we get it done. We can add it in the next release though.

[pa-nathaniel]

Got it, thanks for the info @ablack3!

I'm curious if I wanted to try creating a PR to add this, what would the steps look like?

Is there another merged PR that adds similar functionality that could be used as a reference?

You mentioned Atlas and Circe, just to clarify would this also require an update to Circe (I think 'no' but just want to clarify)

[pa-nathaniel]

Awesome makes sense. Thanks very much for the detailed developer instructions.

And just let me say again awesome package!!! The more I use it the more I love it.