Coder Social home page Coder Social logo

Comments (5)

pepso avatar pepso commented on August 10, 2024

Hi @exextoc,

I understand the underlying JS engine the Classic Outlook launch events uses is based on V8, and by default the i18 / Intl support should be enabled during the compilation time. Does the ICU 75 update from April explain the dropped support?

Do we expect the support for Intl in Classic Outlook to be back in the upcoming Outlook releases?

We resorted to implement our Add-in without Intl package dependency for non-marketplace clients. We'd love to know this before we update the marketplace manifest version listing.

I noticed the current channel release notes were talking about character issues and decided to update the Outlook to the latest version and can confirm our add-in is still executed in an environment without Intl package:

Following code in action function:

console.log("Testing Intl Support...");
console.log("Intl typeof?", typeof Intl);
console.log("Intl available?", Intl ? true : false);

Results to following OfficeAddins.log.txt entries:

12/07/2024 11:36:51	Verbose	Runtime	[Console] [Log] Testing Intl Support...		
12/07/2024 11:36:51	Verbose	Runtime	[Console] [Log] 'Intl typeof?', 'undefined'		
12/07/2024 11:36:51	Verbose	Runtime	[Console] [Log] ReferenceError: Intl is not defined
12/07/2024 11:36:51	Unexpected	Runtime	[Error] [Log] ReferenceError: Intl is not defined
Object.h [as error]
foundation.win32.bundle:57:1965
Object.error
C:\FOLDER\bundle.js:53:24
Object.error
C:\FOLDER\bundle.js:66:22
_callee$
C:\FOLDER\bundle.js:7640:12
tryCatch
C:\FOLDER\bundle.js:7581:1061
Generator.<anonymous>
C:\FOLDER\bundle.js:7581:3007
Generator.next
C:\FOLDER\bundle.js:7581:1698
asyncGeneratorStep
C:\FOLDER\bundle.js:7582:69
_next
C:\FOLDER\bundle.js:7583:162
u
foundation.win32.bundle:70:156


from office-js.

ztcdsb avatar ztcdsb commented on August 10, 2024

@pepso We didn't disable Intl package as far as I am aware. I am not an expert in this area so I'm not sure if this is related to ICU75 update.

If it's missing indeed, it will require a feature request to specifically to add it.

from office-js.

pepso avatar pepso commented on August 10, 2024

Hi @ztcdsb thanks for the message.

I find this a bit concerning: Intl used to be part of the launch event environment (Chakra JS engine), it was dropped as part of migration to V8, and now we need to create a feature request to support it like it used to?

from office-js.

ztcdsb avatar ztcdsb commented on August 10, 2024

@pepso Well, we recently rolled out V8 to everyone, but V8 was already the default engine for debugging event based add-ins for a while because Chakra does not support VS code debugging.
Do you recall if you had the same issue when debugging event based add-ins before?

from office-js.

pepso avatar pepso commented on August 10, 2024

Hi @ztcdsb,

I have been running Intl package functionality on local development machine (debug flag on, which should mean the engine used was V8 as far as I am aware) for quite some time, including on 26th of April, when I resolved an underlying issue of required parameters (Intl.NumberFormat) being different between the JS engine implementations.

All this is to say the Intl package was present, and only since then gone missing:
#4391 (comment)

Also as mentioned in the original description of the issue, Outlook Classic 2406 (Build 17726.20126) was the first where the Intl package was missing on admin installed launch event Add-ins.

What I noticed while we developed the workaround to Intl package being missing is that many (like ~75% of common Intl replacement libraries) rely on Intl package and checks for certain function implementations (i.e. Intl.NumberFormat), which all end up being "silent failures" when attempting to use those are part of the bundled Add-in code.

from office-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.