Broken "Always remember my choice for this application" checkbox and "Open" button for Excel Add-in's warning dialog about office-js

[peterle1906]

Hi @shanshanzheng-dev, it is the same manifest that I sent you previously, I just removed some of the generics like names and Id to keep confidential privacy.

https://github.com/peterle1906/file/blob/main/manifest-test.xml

[peterle1906]

Hi @shanshanzheng-dev, I just verify this one with my colleagues and seems like we all have the same error, I will try to create a small demo and send you a github repository link to test it

[shanshanzheng-dev]

Hi @peterle1906 Thanks for these detail information, for the second bug, I saw there is a latest version, you can try if you can repro.

https://learn.microsoft.com/en-us/officeupdates/update-history-microsoft365-apps-by-date
For my excel version, I can't repro this.

for the first bug, we'll look into if this is a style conflict. Thanks.

[shanshanzheng-dev]

Hi @peterle1906 Thanks for reporting this issue. Could you share your test manifest to help us investigate this issue better? Thanks.

[peterle1906]

Hi @shanshanzheng-dev, yes, here's the manifest file
https://github.com/peterle1906/file/blob/main/manifest-test.xml

[shanshanzheng-dev]

Hi @peterle1906 Thanks for providing this manifest. this manifest works good on my side. I understand your concern. If possible, could you share your test code or your repro video? We're trying to repro your issue. Thanks.

[peterle1906]

Bug.mp4

I'm using Angular and I noticed that the dark screen didn't appear on any blank component, just wondering if this is a style conflict.

Also for the link in the blank screen, the Excel addin crashed and my machine went into a frozen state after I spam click the button. I'm not sure if this is because of my machine or because the bug, but I think it's worth to mention that

For the code, it just html with
<a style="top: 50; left: 50;" href="onenote://">This is an a tag with href='onenote://'</a>

[shanshanzheng-dev]

Hi @peterle1906 Thanks for these detail information, we'll be looking into this issue. In order to help us investigate, could
share us that Active Workpapers(Loacl) manifest? Because use my test add-in, I can't repro your problem. We will come back if we have a suggestion for you. Thanks.

[shanshanzheng-dev]

Hi @peterle1906 Sorry, I try to use your manifest, but I get a error.

For test add-in, open warning dialog works good:

Screen.Recording.2024-06-27.at.12.05.53.mov

[peterle1906]

Hi @shanshanzheng-dev, I have tested the bugs again on several machines and have observed some results:

1. The second bug, when click "Always remember my choice for this application", it will not open any external link, only happen on Excel add-in version Microsoft® Excel® for Microsoft 365 MSO (Version 2404 Build 16.0.17531.20190) 64-bit, which I believed is the latest version. I tested with a machine on version Microsoft® Excel® for Microsoft 365 MSO (Version 2403 Build 16.0.17425.20236) 64-bit and couldn't reproduce the error.
2. For the first bug where the screen turns dark, we have spotted that this error only happen inside modal components or attempt to open a modal components after the warning dialog appear

This is our modal service to open a modal, using Bootstrap NgbModal

export const OVERLAY_DATA = new InjectionToken<{}>('OverlayData');

export interface ModalResponse<T = any> {
  id?: string;
  action: 'Add' | 'Update' | 'Delete';
  model?: T | null;
}

type BeforeDismissAction = ReturnType<NgbModalOptions['beforeDismiss']>;

@Injectable({
  providedIn: 'root'
})
export class ModalService {

  overlayPortal: Portal<any>;

  private _openedModals: NgbModalRef[] = [];

  constructor(private readonly _ngbModal: NgbModal,
    private _injector: Injector) {
  }

  openModal<T>(content: any, id: string = null, params: any = {}, options?: NgbModalOptions, beforeDismissAction?: (component: T) => BeforeDismissAction): Promise<any> {
    const consolidatedOptions = { ...{ size: 'lg', backdrop: 'static' }, ...options };
    if (content.modalSize) consolidatedOptions.size = content.modalSize;
    const modalRef = this._ngbModal.open(content, {
      ...consolidatedOptions,
      beforeDismiss: consolidatedOptions.beforeDismiss ?? (beforeDismissAction ? (() => beforeDismissAction(modalRef.componentInstance)) : null),
    } as NgbModalOptions);

    this._openedModals.push(modalRef);
    merge([modalRef.closed, modalRef.dismiss]).pipe(take(1)).subscribe(() => this._openedModals = this._openedModals.filter(m => m !== modalRef));
    if (id) modalRef.componentInstance.id = id;
    if (params) modalRef.componentInstance.params = params;
    return modalRef.result;
  }
}

I hope this help, let me know if you need more information

[peterle1906]

Hi @shanshanzheng-dev, sorry for the late reply. I can confirm that updating to version 2406 solved the second bug for excel. But the first bug still exist

[shanshanzheng-dev]

Hi @peterle1906 Thanks, about the first bug, we'd like to confirm with you, that is a style conflict. We recommend you to submit a new Tech Community New Ideas item, this will give us visibility of the commonality of it and will help with our prioritization. If we end up working on this issue, we will re-activate as needed.    Microsoft 365 Developer Platform - Microsoft Community Hub

[microsoft-github-policy-service]

This issue has been automatically marked as stale because it is marked as needing author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your interest in Office Add-ins!

[microsoft-github-policy-service]

This issue has been closed due to inactivity. Please comment if you still need assistance and we'll re-open the issue.