installing app via App Studio pre-defined template fails about microsoft-teams-samples

[Wajeed-msft]

@akatrukhin, @asnow003 - Could you please help to check this?

[akatrukhin]

Sorry @antontru, everything looks as expected. Just tested and can't catch the same issue.
Would you able to open help me and understand why it's happening:

1. Could you test this link in your browser and check if it's respond https://officedev.github.io/microsoft-teams-app-sample/#/ ?
2. @asnow003 Is it could be relative to manifest schema version or Teams version?
3. @antontru could you try to install app sample package directly by your own?
   In the Teams client, go to Apps.

Select Upload a custom app and upload the app package, which is the generated zip file in the package folder.

[yakall]

Hi @akatrukhin
Have similar issue with this app package.

1. built from the source - when trying install package in Teams client, error message is [...]Error while reading manifest.json: "validDomains[0]" is required
   manifest.json contains "validDomains": ["{{HOSTNAME}}"]

2. using ready to install package from https://aka.ms/teamsuisampleapp error message is [...]Error while extracting package: Please ensure there are no folders in your app package and that your app package contains only the manifest.json and the two required icon files at its root level. For an easier experience creating your app package, install App Studio from the Teams Store.[..]
   In the package zip file found folder 'microsoft-teams-app-sample' and all required files inside this folder.
   Is this structure valid?

[belasor]

Hey guys,

the problem is really easy to fix.
The domain which is in the manifest is wrong, if you change this:
"validDomains": ["officedev.github.io/microsoft-teams-app-sample/#"],
to this it will work:
"validDomains": ["officedev.github.io"],

Explanation:
I think teams is only accepting the top level domain and nothing else.