Comments (6)
Go for it
from generator-office.
Aye sir!
from generator-office.
I'll wait with fixing this issue until we get the fix for #42 in place. That way we can do it all at once both for Angular and Angular ADAL.
from generator-office.
Sounds good
from generator-office.
If we apply the modifications we won't be needing jQuery anymore, unless you want to use some Office UI Fabric components. How about we leave the jQuery reference in https://github.com/OfficeDev/generator-office/blob/master/generators/taskpane/templates/ng/_bower.json#L6 but comment it out in https://github.com/OfficeDev/generator-office/blob/master/generators/taskpane/templates/ng/index.html#L9 so that it is still there and can easily be enabled if you'll want to use Office UI Fabric which requires jQuery (https://github.com/OfficeDev/generator-office/blob/master/generators/taskpane/templates/ng/index.html#L25)?
from generator-office.
Personally, if its not used, I’d remove it all together. Leaving commented code in starter templates always makes me wonder if that was left by mistake. People can add it quite easily if they want it.
And you don’t need jQuery if you use fabric… you only need it for some of the components, not all.
from generator-office.
Related Issues (20)
- Cannot Remove Default Add-In HOT 3
- Generated vscode tasks.json file has invalid scripts that fail HOT 1
- Request to add more a hybrid template between modern ui (React) and custom functions HOT 2
- Outlook add-in disappearing after side loading in outlook app HOT 4
- Errors when creating new addin HOT 8
- Cannot find module 'is-ci' on ubuntu HOT 2
- How to install certificate on ubuntu without user interface? HOT 3
- The --prerelease switch doesn't fetch prerelease branch when JavaScript chosen HOT 1
- Running thru a proxy/corp environment
- Cannot select Typescript HOT 2
- Why is Angular not an option in "Choose a Framework"? HOT 1
- Node 20 not supported HOT 1
- unexpected behavior when compiling on a filesystem with other case-semantic in yo office add-ins HOT 7
- Update Deps HOT 2
- Unable to install CA cert for local development on Windows 10 with VSCode HOT 1
- Issues with registry value using npm start HOT 6
- Source file is corrupted when fetched from the Office-Addin-Taskpane-SSO repo HOT 2
- Remove Add-In HOT 3
- Changing accounts for generator offoice HOT 2
- Sideloading fails with invalid scope HOT 19
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from generator-office.