Coder Social home page Coder Social logo

Comments (6)

andrewconnell avatar andrewconnell commented on May 22, 2024

Go for it

from generator-office.

waldekmastykarz avatar waldekmastykarz commented on May 22, 2024

Aye sir!

from generator-office.

waldekmastykarz avatar waldekmastykarz commented on May 22, 2024

I'll wait with fixing this issue until we get the fix for #42 in place. That way we can do it all at once both for Angular and Angular ADAL.

from generator-office.

andrewconnell avatar andrewconnell commented on May 22, 2024

Sounds good

from generator-office.

waldekmastykarz avatar waldekmastykarz commented on May 22, 2024

If we apply the modifications we won't be needing jQuery anymore, unless you want to use some Office UI Fabric components. How about we leave the jQuery reference in https://github.com/OfficeDev/generator-office/blob/master/generators/taskpane/templates/ng/_bower.json#L6 but comment it out in https://github.com/OfficeDev/generator-office/blob/master/generators/taskpane/templates/ng/index.html#L9 so that it is still there and can easily be enabled if you'll want to use Office UI Fabric which requires jQuery (https://github.com/OfficeDev/generator-office/blob/master/generators/taskpane/templates/ng/index.html#L25)?

from generator-office.

andrewconnell avatar andrewconnell commented on May 22, 2024

Personally, if its not used, I’d remove it all together. Leaving commented code in starter templates always makes me wonder if that was left by mistake. People can add it quite easily if they want it.

And you don’t need jQuery if you use fabric… you only need it for some of the components, not all.

from generator-office.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.