Comments (4)
First, thanks a lot for this library! (I really need to emphasis gratitude for this work, it makes my life much easier!)
Ahh, I see. That makes sense to put it there.
As a note: Me, like many others, reference the library using the ^-operator. We actually had ^1.16.1 in the package.json file. While i know it is good form to have tighter bounds on the versioning, I think most people agree that this is the way to keep up to date with new functions. As such, a breaking change like this would probably have been better to push to a major update, where people have to consider updating the package.
Anywho, I see that the release was cut yesterday, so we will probably see some people wake up to see some failing pipelines today :)
Again, thanks a lot!
from generouted.
A proposal to alleviate that would be to keep the export to const Modal = () => null
and then remove the export from version 2 and forward.
from generouted.
@madsbuch Thanks, very glad to hear that!
Thanks for the suggestion, I've included an empty Modals
export with a deprecation warning at v1.19.2
from generouted.
@madsbuch Thanks for reporting this.
There was a note about that at the v1.19.0 release notes. The Modals
export is no longer available/need as it's included internally.
from generouted.
Related Issues (20)
- Vitest error when colocating .test.tsx file with component HOT 8
- Feature Request: Programmatically Handling Routes HOT 4
- No HMR in Action - need to refresh HOT 3
- Feature: Support React Query in React Router HOT 1
- blank page, but generouted scanned my route correctly HOT 3
- Custom path not working HOT 2
- Parentheses directories with a hyphen in the name HOT 1
- Support for .mdx extension HOT 4
- Issues importing @generouted/react-router/client in jest HOT 8
- Stackblitz link is broken HOT 1
- Generated routes output is sometimes not fully written to disk before being processed HOT 1
- How to extends Link component from router file HOT 9
- Can I setting a different entry point instead of './src/router.ts'? HOT 5
- Question: "guard routes" ? HOT 2
- Dynamic Link provided in <Link to /> HOT 4
- Question: usage without TypeScript HOT 3
- Folders without an index file create empty routes HOT 1
- Loaders are executed twice when using React.StrictMode HOT 1
- Modals.close at doesn't redirect when with params HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from generouted.