sale_stock: company_id is not saved after changing warehouse about odoo

[yelizariev]

If I understand correctly, odoo don't save readonly attributes after this commit
2328040

[pna-odoo]

Hello,

Thanks for your good explanation, I have reproduce same at my end.

So I am confirming this issue. Regarding your fix i am not agree with you as you cannot remove readonly, instead we have to improve code so we can save it.

Thanks,
Pinakin

[msh-odoo]

Hello Yelizariev,

This does not looks an issue at all, this is the desired behavior of Odoo web-client that it does not send values of readonly field.

"Its design decision"

If you want to save readonly field's value forcefully then you can achieve logically in your module(there are many ways), like you can override create method and apply the logic which adds readonly field and its value(may be by recalling onchange method from create in your case) in vals which going to save.

Readonly fields are for informative purpose.

For further information you can go through comment : https://bugs.launchpad.net/openobject-client/+bug/378824/comments/18

Hope this will help.

Thanks,
Mohammed

[yelizariev]

Mohammed, this is issue about company_id field, is not about design decision. I only need company_id corresponded to warehouse_id. I agree with any solution on this.

Another solution is as Fabien commented https://bugs.launchpad.net/openobject-client/+bug/378824/comments/2

May be you can do what you need with a hidden but not readonly field.

[KangOl]

No, the solution is to change the field "company_id" to be a stored related field.

[rafaelbn]

cc @pedrobaeza @antespi @yajo @sergio-incaser @carlos-incaser

[rafaelbn]

@yelizariev it's much more effective if you make a PR to Odoo fixing it.
Also you can make a PR to https://github.com/OCA/OCB fixing the problem and have it solve it

[JKE-be]

@rafaelbn, @yelizariev it's not an issue for Odoo... so don't need to be fixed. Odoo don't save the readonly field, it is by design.
Confirmed by @KangOl (#171 (comment)) and https://bugs.launchpad.net/openobject-client/+bug/378824/comments/2

[andreinl]

@JKE-be, so storing Warehouse with company_id from another Company is not a problem?

[JKE-be]

@andreinl not exactly. The fact that field readonly is not saved is not an issue. The fact that you can store "Warehouse with company_id from another Company" yes. But the discuss was confusing. The fix as suggest @KangOl will be to change the field "company_id" to be a stored related field. or keep the onchange but remove the readonly and add the invisibility.

[andreinl]

@JKE-be The other solution can be intercept create() and write() and write company_id from warehouse. Users will always see the right company as onchange works fine. It seems to me that this is less intrusive solution.

[Yenthe666]

Dear @yelizariev,

Thank you for reporting this issue!
At this point Odoo 6.0, 6.1 and 7.0 are no longer supported for bugsfixes anymore, which means we will no longer handle these bugs.
If you still face this issue on Odoo 8, 9 or 10 we'd like to ask you to create a new issue on how to reproduce this.
Our apologies.

Regards,
Yenthe

[yelizariev]

@Yenthe666
this issue is for 8.0 and need updates mentioned here #171 (comment)

[Yenthe666]

@JKE-be and @KangOl could you guys give feedback on this and get this going?

[Yenthe666]

Hi @yelizariev ,

Again a bit thank you for the report.
At this point Odoo 8 is no longer supported as Odoo only supports three versions (9.0, 10.0, 11.0 at the moment).
If you can still reproduce this issue on Odoo 9, Odoo 10 or Odoo 11 we encourage you to create a new bug report.

Regards,
Yenthe