Coder Social home page Coder Social logo

Comments (4)

oddvalue avatar oddvalue commented on June 26, 2024 2

Yeah, something's definitely not right. Will take a look, thanks 🙂

from laravel-drafts.

oddvalue avatar oddvalue commented on June 26, 2024 2

Right, been through it all and found a bug in the separation of the Publishes and HasDrafts traits. The Publishes trait was setting the is_published column to true on the record that the publish method was called on. I've moved things around to prevent that and added @jaysson's test.
Use v1.0.2 and you should be good to go 🙂

from laravel-drafts.

SergkeiM avatar SergkeiM commented on June 26, 2024

Hi @jaysson have same issue, when Publishing, Draft becomes published, but is not current, and old revision becomes, current and marked as published :/

from laravel-drafts.

SergkeiM avatar SergkeiM commented on June 26, 2024

Hi @oddvalue

I think the problem is here:

public function setLive(): void
    {
        $published = $this->revisions()->excludeRevision($this)->published()->first();

If I'm editing a draft and call ->publish() it will exclude it and get the previous (currently published) and mark it as current.

So prevous published record always becomes current and published.

from laravel-drafts.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.