Accept $base-font-size in any unit about susy

[mirisuzanne]

Well, you sure got that one wrong. :)

If you look around even a little, you'll see that all the Susy defaults are in ems, the 'getting started' tutorial uses ems, the site itself uses ems, and the only demo posted uses ems. In fact, Susy was built for the sole purpose of using ems - I just opened it up to other units for flexibility. I'm actually surprised every time someone uses px.

If you're getting that error, you've referenced px somewhere - because I sure haven't. :)

[Snugug]

Hmm, interesting. Very interesting. I'm about 99% sure I don't have any px anywhere because I was making a point of converting to ems before passing into Susy, but I guess I've gotta go dig a little deeper. I'll see what's up.

And, whoops!

[mirisuzanne]

I may have been over-zealous. There is one place we assume a px setting - because Compass does (and converts it to ems for you, if you use vertical rhythms). That setting is $base-font-size. Could that be the culprit?

It's actually important that $base-font-size be set in px, because we need a way to compare your font size with the usual browser default when you use ems for the grid. That's because em-sized media-queries ignore your font-size settings, and are figured in relation to the browser default.

If that is the problem, there's no "fix", but I should probably get it thoroughly documented.

[Snugug]

Yup, that's exactly the issue.

This is happening in relation to Aura, which has that initial comparison built in and converts whatever you throw at it (px, me, %, pt) into ems based on browser standards, which it sounds like you're doing in Susy.

So yes, documentation for that would be great, and should solve my issue. My final question is, is there a reason other than "that's how Compass does it" that you're assuming px and not allowing for anything to be put in there, with the assumption being that if you pass in something that isn't px it'll convert whatever it is to ems based on the browser defaults? Again, I understand that the browser uses its default ems for em-sized MQs, so when conveying px based MQs into EM based MQs, shouldn't you not care what unit $base-font-size is in and simply go with the default conversion?

On Thursday, June 7, 2012 at 1:16 PM, Eric Meyer wrote:

I may have been over-zealous. There is one place we assume a px setting - because Compass does (and converts it to ems for you, if you use vertical rhythms). That setting is $base-font-size. Could that be the culprit?

It's actually important that $base-font-size be set in px, because we need a way to compare your font size with the usual browser default when you use ems for the grid. That's because em-sized media-queries ignore your font-size settings, and are figured in relation to the browser default.

If that is the problem, there's no "fix", but I should probably get it thoroughly documented.

---

Reply to this email directly or view it on GitHub:
#57 (comment)

[mirisuzanne]

Yep, probably. I just borrowed it directly from Compass Vertical Rhythms and figured it would work. My mistake. :)

Re-opening. Any interest in submitting a patch?

[Snugug]

Yes, yes I will. Expect it later today/tomorrow.

Sam Richard
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Thursday, June 7, 2012 at 1:34 PM, Eric Meyer wrote:

Yep, probably. I just borrowed it directly from Compass Vertical Rhythms and figured it would work. My mistake. :)

Re-opening. Any interest in submitting a patch?

---

Reply to this email directly or view it on GitHub:
#57 (comment)

[mirisuzanne]

You rock. Thank you much.

[Snugug]

No sir, that you very much!

On Thursday, June 7, 2012 at 1:35 PM, Eric Meyer wrote:

You rock. Thank you much.

---

Reply to this email directly or view it on GitHub:
#57 (comment)

[Snugug]

Here's the pull request, a day late, but here it is!
#58

[mirisuzanne]

Closed by #58