Comments (10)
why not both? Maybe start a PR with Deno tests, without removing the existing tests, and we take it from there?
from webhooks-methods.js.
Thanks for reporting this!
Just to clarify, do the example values you provided in your issue trigger this error? (I haven't had a chance to test yet.)
Would you be open to making a PR to fix this? I'd be happy to review your contribution!
from webhooks-methods.js.
Thanks for reporting this!
Just to clarify, do the example values you provided in your issue trigger this error? (I haven't had a chance to test yet.)
Would you be open to making a PR to fix this? I'd be happy to review your contribution!
yes
I think any signature that starts with something other 2 or more non-hex characters will reproduce
from webhooks-methods.js.
I'll see if I have time to make a PR sometime today or tomorrow
from webhooks-methods.js.
Looks like a Deno error to me, I cannot reproduce it with Node. Tested with Node v18.8.0 and v16.17.0.
Unfortunately the libraries are not native ESM yet, Deno is using a built version of the code base served from skypack.dev, the build step might also be the culprit here.
from webhooks-methods.js.
I see there are some browser tests. We can confirm if it is broken by adding additional test cases there first.
from webhooks-methods.js.
The browser version is completely independent of the node implementation. In fact, I think the browser version has some other behavior differences too. e.g. I have to strip "sha256=" from the signature before passing it into verify
for the browser/web version too work.
from webhooks-methods.js.
It might be worthwhile to write the browser/web tests in Deno. Any concerns with me dropping puppeteer in favor of Deno here?
from webhooks-methods.js.
initial Deno tests PR: #81
from webhooks-methods.js.
I think the proper thing to do is to catch these errors and handle them in your own code.
We are switching to outputting ESM in the next major version, which should help out with these things
from webhooks-methods.js.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webhooks-methods.js.