Inconsistency in issue label endpoints in rest.js about discussions

[kytrinyx]

Yeah, this feels like something that is worth a full audit rather than piecemeal itty-bitty fixes. I'm happy to help gather more potential cases, though at the moment I've not given it any concerted effort, just randomly came across this one.

[gr2m]

Yeah I agree it would be nice if we could make these more consistent. I don’t have a strong preference on wether using name/names or label/labels, but I agree that either is better than name/labels.

I think it would probably be simpler to do label/labels as it wouldn’t need to require any implementation changes for the REST API, only an update of the docs. Instead of

DELETE /repos/:owner/:repo/issues/:number/labels/:name

We would have

DELETE /repos/:owner/:repo/issues/:number/labels/:label

On the client side, we could implement aliases and log deprecation warnings for some time to make the transition easier.

If we want to move forward with it, we should look for more cases that are similar, for example

• GET /repos/:owner/:repo/labels/:name
• DELETE /repos/:owner/:repo/labels/:name

I planned to do a full audit of the octokit/rest.js/lib/routes.json file anyway if you’d like help to gather more potential cases we could harmonize?