Coder Social home page Coder Social logo

Comments (3)

gr2m avatar gr2m commented on May 23, 2024

I’ll put that on hold for now and wait until we made sure that this is indeed helpful for Probot and similar frameworks. I could see it being confusing that the same method call auth() can return different things based on the factory options.

from auth-app.js.

gr2m avatar gr2m commented on May 23, 2024
const auth = createAppAuth({
  id: 1,
  privateKey: "-----BEGIN RSA PRIVATE KEY-----\n...",
  installationId: 123
});

new Octokit({
  auth
});

The auth option for the Octokit constructor would retrieve the current request options which includes the .url property (this is not implemented that way, but that’s what I plan to do). So the correct authentication method would be used automatically based on the endpoint used 🤔 That’s pretty neat.

from auth-app.js.

gr2m avatar gr2m commented on May 23, 2024

that's done

from auth-app.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.