Comments (4)
Oh, wow, I'm honored!
I just tested it from a fresh ubuntu-18.04.4-desktop-amd64.iso installation and I needed these packages:
CUSTOM_DEPS += libcairo2-dev libgtk-3-dev libglib2.0-dev libgtksourceview-3.0-dev libgirepository1.0-dev pkg-config cmake
pkg-config
and cmake
were needed for opencv-python-headless and everything else for GTK. After that pip install browse-ocrd
succeeded.
I have some hesitations about the inclusion in ocrd_all:
- I was wondering if it is a good idea to include browse-ocrd in ocrd_all, because it will drag in a lot of GTK/desktop package dependencies to ocrd_all, and that might become annoying for pure server usage (but with OCRD_MODULES it's easy to select/deselect modules, so maybe that's ok).
- I have absolutely no idea if this can work in a Windows or macOS environment, and I won't be able to maintain this. Actually it's only ever tested on Ubuntu18.04 and 20.04
- I'm not sure if the code is mature enough, I'm still trying a lot of things, restructuring the code, there are unimplemented things and quite some possibilities for crashes
- Also I'm still not sure if it should become more of a mets.xml viewer or editor. My use case as a scan/preview tool needs some editing capabilities (that is: delete via right-click in the pagebrowser), but I don't want to take the responsibility for broken mets files ;)
So, with that said, if it is ok for you, it's ok for me. And I would be happy if more people would use it.
from ocrd_all.
ping @hnesk
from ocrd_all.
I understand and share your concerns @hnesk, appreciate your pragmatism. But let's keep this issue open and revisit later once the tool has matured and we have discussed how ocrd-browse would fit into the ocrd_all stack.
from ocrd_all.
@hnesk thanks for your thorough explanation!
* I was wondering if it is a good idea to include browse-ocrd in ocrd_all, because it will drag in a lot of GTK/desktop package dependencies to ocrd_all, and that might become annoying for pure server usage (but with OCRD_MODULES it's easy to select/deselect modules, so maybe that's ok).
That's a good point. So far we have tried to eliminate X11 dependencies whereever we can (e.g. prefering opencv-python-headless
over opencv-python
). But we never had any actual dedicated GUIs to begin with (except for debugging facilities).
We could include your module in such a way that unsupported platforms don't install it when using ocrd_all natively (see conceptual discussion in #147). For our Docker prebuilds, we should probably exclude it.
* I have absolutely no idea if this can work in a Windows or macOS environment, and I won't be able to maintain this. Actually it's only ever tested on Ubuntu18.04 and 20.04
Understood. Don't bother!
- I'm not sure if the code is mature enough, I'm still trying a lot of things, restructuring the code, there are unimplemented things and quite some possibilities for crashes
That's true for most modules though (except for the crashes). But since will not be part of the productive processes, and already has value, I don't think we should be too concerned about this.
* Also I'm still not sure if it should become more of a mets.xml viewer or editor. My use case as a [scan/preview tool](https://github.com/hnesk/browse-ocrd-physical-import) needs some editing capabilities (that is: delete via right-click in the pagebrowser), but I don't want to take the responsibility for broken mets files ;)
Of course. If users change their METS with anything other than a processor, they must be sure to keep backups etc. This is similar to the case with ocrd-sanitize
.
So, if there are no other objections, I'll make a PR along those lines.
from ocrd_all.
Related Issues (20)
- Native installation - got exception during 'sudo make deps-ubuntu' HOT 17
- Error during native installation on Ubuntu 22.04 HOT 9
- build ocrd fails HOT 12
- segmentation: tesseract5.3.0 vs ocrd/all:2022-08-15 HOT 10
- make all: torch depends on typing-extensions? HOT 5
- sbb-binarize: 'int' object is not subscriptable HOT 4
- make all failed with latest release (2023-02-06) (with "shapely") HOT 17
- Did-you-read-the-manual test? HOT 2
- tesserocr-deskew - directory $TESSDATA_PREFIX ? HOT 12
- I could find "core" version 2.47.3 with installation of latest ocrd_all (v2023-02-06) HOT 3
- recursive clone of ocrd_fileformat bloats docker with assets HOT 4
- recursive clone of ocrd_olena bloats docker image with assets HOT 3
- sbb-binarize ocrd resmgr download ...: SavedModel file does not exist ... __MACOSX HOT 2
- selection via OCRD_MODULES fails due to dependent modules HOT 4
- "I have no name!" in prompt after logging in to container HOT 2
- error in ocrd-tesserocr-deskew: PyTessBaseAPI.__cinit__ HOT 2
- eynollah: contour data type = 17 is not supported HOT 4
- ocrd_all - Release v2023-06-14 - issue with GPU HOT 14
- docker: mixing preinstalled and user-downloaded resources HOT 12
- "make all" creates "fatal error" with "submodule 'ocrd_fileformat'" (but goes on...) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ocrd_all.