Drag and Drop from Menubar about imgui

[GamingMinds-DanielC]

You need to call BeginDragDropTarget() after submitting any widget that you want as a potential drop target. And definitely not inside of a BeginDragDropSource() conditional. Take a look at the drag&drop copy/swap example in the demo window for reference.

[ocornut]

(Note that I added an assert to detect nested BeginDragDropTarget()/BeginDragDropSource(), but this specific error won't be caught as it is merely in the conditional block)

[BraunSilas]

@GamingMinds-DanielC yes you are correct let me fix that. Reading through the documentation and applying your feedback I get get to this code.

`
ImGui::BeginMenuBar();
if(ImGui::BeginMenu("Menu")){
ImGui::MenuItem("Item");
if (ImGui::BeginDragDropSource(ImGuiDragDropFlags_None)) {
ImGui::SetDragDropPayload("DND_DEMO_CELL", &taken, sizeof(int));
SDL_Log("test works");
ImGui::Text("Swap %s", taken);
ImGui::EndDragDropSource();
}
ImGui::EndMenu();
}
ImGui::EndMenuBar();

ImGui::BeginChild("drop here");
ImGui::EndChild();
if (ImGui::BeginDragDropTarget()) {
    if (const ImGuiPayload *payload = ImGui::AcceptDragDropPayload("DND_DEMO_CELL")) {
        SDL_Log("Droped :%d", taken);
    }
    ImGui::EndDragDropTarget();
}

`

It does run, but I am still not able to begin the DragDropSource.(as in I still don't see a tooltip or the SDL.Log).
Am I making any other mistakes?

[GamingMinds-DanielC]

One mistake I see is that you call ImGui::EndMenuBar() unconditionally. Everything after ImGui::BeginMenuBar() up to and including ImGui::EndMenuBar() must be called if and ONLY if ImGui::BeginMenuBar() returns true.

That's not why it doesn't work though. I have never tested drag&drop with menu items before, but a quick test suggests that ImGui::MenuItem() doesn't support it. Since you can put any type of widget inside of a menu, try replacing your menu item with ImGui::Selectable(), that should work.

[BraunSilas]

Thank you @GamingMinds-DanielC
You're the boss!

@ocornut It would be nice for MenuItem() to support drag and drop.
Its not a must, since we can exchange it. but it would be convenient and intuitive.