Output is image URL only shows icon, but not the image about obs-urlsource

[royshil]

I think I need to do some work on accepting local file paths for images
It's not a big deal. I can get it done quickly

[nona00]

Thank you very much for the hint. I tried the new version, but the issue is the same, only an icon is shown. I was able to reproduce it with a simple text input. I tried with C:/Test/test.jpg and C:\Test\test.jpg

test.txt

[royshil]

ive merged #61 . the problem is fixed
i also added further controls, so i'll be closing this issue
thanks @nona00

[nona00]

OBS 30.0.0 x64 win

[royshil]

@nona00 can you give me some more details?
like what does the response body look like?

[nona00]

[nona00]

[royshil]

right... it's a local file...
you might be able to get away with adding a prefix like file:// before the C:/...
may be possible with the postprocessing regex...

[nona00]

i tried with file://C:/... and also with an url, but both do not work. Is it perhaps necessary to adapt CSS Properties or Output Template? In Output text source it is only possible to select "None / internal rendering" or Text or Media, but not a picture

[royshil]

@nona00 can you check out the artifcats on #59 ? i've added a bit to see if it's a file (really see if its not a URL and then attempt to open it as a file)

[nona00]

I tried to build from source on Windows 10 x64 1809, but it fails with:

Visual Studio 2022, Powershell 7 and winget is installed

[royshil]

@nona00
You don't actually need to build from source since the CI system builds it for the PR
Grab the version you need from

https://github.com/occ-ai/obs-urlsource/pull/59/checks

Under "artifacts"

[royshil]

@nona00 thanks for this test - i will try to replicate your issue and resolve it on my setup

[royshil]

i'm able to replicate the issue. I will resolve it

[royshil]

@nona00 i've fixed it. can you check the artifcats on #61 ?

[nona00]

wow, thank you very much for the fast fix. I did some tests and it works now :-)

The icon is only shown when the file path is not correct or if the image from the url can not be loaded. An option to display a default File or hiding the element in this case would be great.

I tried to reduce the size of the shown image with the following CSS properties, but it had no effect:
width: 100px;
height: 100px;

Is there another way to do this? For text it works when I set the Output Text Source to an existing text source and define there the size, but for images this seems not to be possible.

[royshil]

@nona00 i've added a property to control the render width on #61
that should allow you to use higher res rendering to fit your needs