Comments (4)
OK, great. The code for this module can be very ugly, so any improvement is welcome. NOTE: I'm not a user of this module nor proper reviewer for it, but general community manager for this kind of kick-off.
from rma.
Can you please do the PR? https://odoo-community.org/page/Contribute
from rma.
Hey @pedrobaeza . Sure we will, we are reworking this method at the moment.
We have better approach for patching this using index to update values from super and not copy/pasting original Odoo method as there are problems with current approach for example:
MAGIC_COLUMNS
are not excluded like in original method.
We are also thinking that tax_line_ids
should be dropped for refund invoice since we noticed problem when refund is made for less lines than original invoice - taxes are wrong (calculated for all lines of original invoice). All this can be easily achieved in this patch method.
If dropped, new tax_line_ids
will be recalculated anyway with _onchange_invoice_line_ids
from rma.
There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.
from rma.
Related Issues (20)
- [13.0] website_rma: The license AGPL-3 conflicts with one of its dependencies. HOT 2
- [13.0] rma_sale: The license AGPL-3 conflicts with one of its dependencies. HOT 2
- [14.0] Permission error on rma_sale module
- [RFC] 14.0 rma_sale: questions about quantities HOT 4
- [13.0] RMA refund amount error when the product price has a discount HOT 2
- [14.0]RMA: Access error for user without settings
- Cant create RMAs for products in a phantom BoM. HOT 1
- Migration to version 16.0 HOT 1
- While replacing a product on RMA order, will it generate a picking order? HOT 2
- Validation error on install rma HOT 1
- Migration to version 17.0 HOT 1
- Add support for serial number HOT 3
- [16.0][BUG] When migrating the rma module from v15 to v16 HOT 4
- The quantity done for the product 'Baby Shanghai Bok Choy' must be equal to its initial demand because the stock move is linked to an RMA (RMA0009).
- RMA - require operation HOT 4
- RMA reason HOT 6
- RMA SO wizard quantity default to 0 and show max HOT 4
- RMA Configure operation for when to generate stock transfer and how to manage invoicing HOT 4
- RMA : configurable workflow HOT 2
- RMA : Manage Lots HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rma.