Comments (9)
Hi. At first glance, i think the problem is not in pos order to sale order module. The module just use export to JSON function that looks to return bad résult
https://github.com/OCA/pos/blob/16.0/pos_order_to_sale_order/static/src/js/CreateOrderPopup.js#L49
Investigation should be done over there.
Thanks !
from pos.
Hi. @xmorejon. As far as I understand, the taxes of the sale order lines, are the taxes on the pos order lines.
See : https://github.com/OCA/pos/blob/16.0/pos_order_to_sale_order/models/sale_order_line.py#L19
Are the pos order line correctly set ?
thanks !
from pos.
Hi,
The POS Order Line are not correctly set:
- Product Price=4,5€
- VAT (21%)= 0,945€
- Recarco Equivalencia (5,2%) = 0,234€
- Total taxes should be: 1,18€
At Product Info / line Level it is not displaying the 0,234€ in the POS Order Line:
But on the Total it is correctly displayed:
Also if instead of generating the Sales Order, we do the Payment on the POS, the receipt will be correctly built:
Could it be that the Point of Sale does a recomputing of the taxes in a later stage, so while preparing Sales Order Lines from the POS Order Lines this Fiscal Position is wrong?
https://github.com/OCA/pos/blob/16.0/pos_order_to_sale_order/models/sale_order_line.py#L19
Thank you so much for looking into it!
from pos.
Well. Could add a screenshot of the pos order taxes in the back-office ?
from pos.
Apologies not sure if I follow you:
- When I do a regular payment in the POS (instead of generating the Sales Order with "pos_order_to_sale_order" module) there is indeed a POS Order in the back-office:
This one corresponds to the receipt of the screenshot Order 00172-001-001. Note that the Taxes are CORRECT.
- But when we generate a Sales order from the POS, there is NO "POS Order" so I cannot make a screenshot:
No available POS Order: Order 00167-001-0001
But corresponding Sales Order in the back-office do miss the Fiscal Position items:
Should I look somewhere else?
Merci Sylvain!
from pos.
Hi again!
Forcing a recompute of Taxes, did the trick and seems to fix the issue! :)
And now the Sales Order has the correct Fiscal Position included:
As mentioned, I am pretty new to ODOO, and not sure if this way of fixing the issue is correct.
Therefore, I would wait for feedback and not suggest this pull request.
Thank you,
Xavier Morejon
from pos.
could you add a print(order_data)
here : https://github.com/OCA/pos/blob/16.0/pos_order_to_sale_order/models/sale_order.py#L13 ?
and put her the result.
thanks !
from pos.
Hi,
Here you go. (Order with 2 lines):
{'name': 'Order 00188-001-0001', 'amount_paid': 0, 'amount_total': 11.36, 'amount_tax': 2.36, 'amount_return': 0, 'lines': [[0, 0, {'qty': 1, 'price_unit': 4.5, 'price_subtotal': 4.5, 'price_subtotal_incl': 5.68, 'discount': 0, 'product_id': 62, 'tax_ids': [[6, False, [1]]], 'id': 1, 'pack_lot_ids': [], 'description': '', 'full_product_name': 'B-0001', 'price_extra': 0, 'price_manually_set': False, 'price_automatically_set': False}], [0, 0, {'qty': 1, 'price_unit': 4.5, 'price_subtotal': 4.5, 'price_subtotal_incl': 5.68, 'discount': 0, 'product_id': 78, 'tax_ids': [[6, False, [1]]], 'id': 2, 'pack_lot_ids': [], 'description': '', 'full_product_name': 'BC-0002', 'price_extra': 0, 'price_manually_set': False, 'price_automatically_set': False}]], 'statement_ids': [], 'pos_session_id': 190, 'pricelist_id': 3, 'partner_id': 11157, 'user_id': 2, 'uid': '00188-001-0001', 'sequence_number': 1, 'creation_date': '2023-12-10T08:50:06.942Z', 'fiscal_position_id': 6, 'server_id': False, 'to_invoice': False, 'to_ship': False, 'is_tipped': False, 'tip_amount': 0, 'access_token': '3eb2f19d-8a81-4299-a0ff-e41ee1dce4df'}
So the Subtotal is right -> 'price_subtotal_incl': 5.68
But there is only one of the TaxID's (corresponding to the 21%) -> 'tax_ids': [[6, False, [1]]]
Thank you.
Xavier
from pos.
Thank you Sylvain!
I believe you are right. As the issue looks to be out of this module, I will close the reported issue.
Will look further into:
But might also apply the "dirty" fix of recomputing the taxes in alternate version of the module. I really need the Fiscal positions to give expected outcome!
Thank you very much. Great job!
Xavier
from pos.
Related Issues (20)
- pos_payment_change for France HOT 3
- OCA/pos: Your 16.0 branch isn't protected HOT 5
- [14.0] pos_no_cash_bank_statement: Bug of savepoint does not exist HOT 2
- oca pos_payment_terminal connection telium HOT 1
- [16.0] pos_default_partner default partner should be visible in pos HOT 1
- After refund of 1 qty, POS qty display increased by 2 qty HOT 4
- [15.0] pos_event_sale : no way to refund hidden event HOT 1
- Error when trying to install [pos_order_reorder] on 15.0 HOT 1
- pos_stock_available_online HOT 3
- Migration to version 17.0 HOT 3
- pos_report_session_summary Error when printing the session summary. HOT 1
- [16] pos_partner_firstname Can't create a contact HOT 10
- [16.0]pos_payment_change change policy option not displayed
- V16 branch looks broken. HOT 8
- RFC: Addition of Customer Postal Code Field in Odoo POS for Enhanced Data Analysis HOT 2
- dos not work with localization HOT 2
- pos_product_packaging_container_deposit - Does'nt add Deposit
- pos_lot_selection - v15 - POS Picking Type's Location is Not Considering
- error on change paiment HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pos.