pip version in Travis build about maintainer-quality-tools

[sbidoul]

Ah, yes, sorry, I misread your original post...

So... I don't know what's happening 🤷

[sbidoul]

So the question is: why is Travis choosing an old version for pip?

I see no reason not to upgrade it.
It is already upgraded but later in the install script. We can do it at the beginning, I think.

Do you want to do a PR ? We can merge and revert if it causes too much trouble.

[SimoRubi]

So the question is: why is Travis choosing an old version for pip?

I see no reason not to upgrade it. It is already upgraded but later in the install script. We can do it at the beginning, I think.

Do you want to do a PR ? We can merge and revert if it causes too much trouble.

Thanks for having a look, I already noticed that pip is upgraded twice in the script and in both cases that happens before installing other packages from requirements:

• MQT_DEP = OCA case:
  

  maintainer-quality-tools/travis/travis_install_nightly

  Lines 108 to 109 in 0ef63c5

  	pip install --upgrade pip "setuptools<58"
  	pip install -q -r ${HOME}/maintainer-quality-tools/requirements.txt

• other cases:
  

  maintainer-quality-tools/travis/travis_install_nightly

  Lines 122 to 127 in 0ef63c5

  	pip install --upgrade pip "setuptools<58" wheel
  	# Needed for tour tests to not be skipped
  	pip install --upgrade websocket-client
  	echo "Installing Odoo"
  	pip install -r ${ODOO_PATH}/requirements.txt -e ${ODOO_PATH}

I think it wouldn't make sense to move it anywhere sooner in the script, that's why I haven't proposed a PR in the beginning.

I'm guessing that maybe the VM/container where Travis is running doesn't have any other more recent version of pip, or maybe it is using an old cached version for some reason?

[sbidoul]

I think it wouldn't make sense to move it anywhere sooner in the script

Why?

[SimoRubi]

I think it wouldn't make sense to move it anywhere sooner in the script

Why?

Because the problem I have found is due to the pip used to install the requirements, so upgrading pip just before installing the requirements should be enough