Hello,

One of our customer wants to have the "INSEE number" on the partner form.

Is there any recommendation of the l10n-france community about that? A first search did not reveal a module doing that.

Hello Alexis

Is your feature request related to a problem?

Yes, it is a problem if a valid yet wrong siren and nic are entered by error for a chorus partner.

Scenario

1. enter valid siren and nic on res.partner
2. click on fr_chorus_identifier_and_required_button to retrieve chorus related information, OK
3. change the siren and nic on the res.partner to another valid siret
4. click again on fr_chorus_identifier_and_required_button, NOK, the information related to the new siret is not retrieved.

Describe the solution you'd like

On having changed the res.partner.siret, a solution would be to either:

1. have the fr_chorus_identifier_and_required_button button (1) delete fr_chorus_service_id on the invoice_partner_id, (2) delete the list of chorus.partner.service related to the partner, (3) reset res.partner.fr_chorus required & (4) res.partner.fr_chorus identifier with the new values related to the new siret.

2. have a new button beside the 'fr_chorus_identifier_and_required_button' button that would (1) set 'res.partner.fr_chorus required' & 'res.partner.fr_chorus identifier' to Null values, (2) delete fr_chorus_service_id on the invoice_partner_id, (3) delete the list of chorus.partner.service related to the partner, so when clicking on the 'fr_chorus_identifier_and_required_button' button, the new correct values for res.partner.fr_chorus required & res.partner.fr_chorus identifier would be set.

A plus would be a message reminding the user to choose from the new list the new fr_chorus_service_id on the invoice_partner_id.

Vincent

cc: @alexis-via

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-12.0

Modules to migrate

• l10n_fr_department
• l10n_fr_department_oversea
• l10n_fr_siret
• l10n_fr_state

When you install the module l10n_fr_department on a DB that already has partners, the field department_id on res.partner stays empty. You have to manually delete the column in the DB and reload the module to get some data.

It seems that the cause of this issue is the following: when you install the module, it starts to create the column in the DB and compute the function fields, and THEN it loads the data of the departments in res.country.department... So, when it computes the function fields, the departments are empty.

Hello,

I have a question regarding withholding taxes.
Is it possible to add this type of taxes to a supplier invoice?

I have a customer in France who needs to pay some freelances.
The legislation forces him to retain the taxes from the total of the invoice.

I searched around but did not find anything (except an italian module for the v7).

Thank you,
David

Hi @alexis-via ,

I would like to have your point of view regarding a migration of chorus pro to v12?
could you help us on this and show us the road ?

Regards

I notice a very small bug in department computation for res.partner ; it supposed that the begin of the zip code can be use for find the corresponding department. It's true for 99%, but in fact there are some exceptions: https://fr.wikipedia.org/wiki/Liste_des_communes_de_France_dont_le_code_postal_ne_correspond_pas_au_d%C3%A9partement

Hi,

When I try to import the line below from a CFONB120 file using account_bank_statement_import_fr_cfonb module, one number for the amount is missing:
0414889 00081XPF0 8261540101806161017 161017VIR A VISIOGREEN AGRICULTURE 00000000 0000000166587J032863054
I get 166587 instead of 1665871. According to our bank "J" stands for "1" in case of debit (see table below) as per the specifications attached.
20130612113947_7_4_Releve_de_Compte_sur_support_informatique_2004_07.pdf

Pour un montant créditeur “7B” et “41” à “49” pour + 0 à + 9 :
• { correspond à 0
• A correspond à 1
• B correspond à 2
• C correspond à 3
• D correspond à 4
• E correspond à 5
• F correspond à 6
• G correspond à 7
• H correspond à 8
• I correspond à 9

Pour un montant débiteur “7D” et “4A” à “52” pour - 0 à – 9 :
• } correspond à 0
• J correspond à 1
• K correspond à 2
• R correspond à 3
• M correspond à 4
• N correspond à 5
• correspond à 6
• P correspond à 7
• Q correspond à 8
• R correspond à 9

What can I do to fix this issue?

Best Regards,

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0

Modules to migrate

• account_balance_ebp_csv_export
• account_bank_statement_import_fr_cfonb
• account_banking_fr_lcr
• l10n_fr_account_tax_unece
• l10n_fr_department
• l10n_fr_department_oversea
• l10n_fr_intrastat_product
• l10n_fr_intrastat_service
• l10n_fr_mis_reports
• l10n_fr_siret
• l10n_fr_state

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

On Odoo 8, when trying to install the module l10n_fr_account_fiscal_position_rule, you get this error:

Exception: Module loading l10n_fr_account_fiscal_position_rule failed: file l10n_fr_account_fiscal_position_rule/settings/account.fiscal.position.rule.template.csv could not be processed:
 Line 1 : null value in column "fiscal_position_id" violates not-null constraint
DETAIL:  Failing row contains (1, 2017-01-17 17:05:40.799667, 10, null, 1, 1, f, null, null, t, 76, null, null, t, 76, 2017-01-17 17:05:40.799667, null, null, France, both, t, null).

This is because, in the module account_fiscal_position_rule, the column fiscal_position_id is now required, but, in the module l10n_fr_account_fiscal_position_rule, the 29 first rules don't have any fiscal position (and it is the right value in this case).

@sebastienbeau Could you fix this ? It breaks travis on l10n-france/8.0...

The goal of this issue is to expose my idea about FEC before I start doing the dev work in OCA. I would like to improve the FEC module l10n_fr_fec on v12 (and probably v10 too):

• add option to choose the encoding (UTF-8, latin1, ...) and maybe also add an option to replace accentuated characters by non-accentuated equivalents
• maybe add other options about the CSV structure (field separator, ...)
• add option to remove the information of the partner on expense, VAT and revenue accounts (only keep it on reconciled accounts)
• replace the .csv extension by a .txt extension

I won't propose a PR on odoo, because it won't be accepted (many PRs are just ignored ; it is impossible to add fields on a stable version).

So my idea would be to maintain a FEC module in OCA. For that, we would take the current l10n_fr_fec as basis and rename it to l10n_fr_fec_oca (or any better name that the community would suggest).
The module l10n_fr_fec from the official addons depends on 'l10n_fr' and 'account' and is auto_install = True.
I have 2 possible solutions in mind :

1. l10n_fr_fec_oca depends on l10n_fr_fec and inherits the menu entry to replace it
2. l10n_fr_fec_oca only depends on 'account' and 'l10n_fr' (and 'date_range'). Users would need to uninstall the l10n_fr_fec manually to avoid the double "FEC" menu entry.

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0

Modules to migrate

• account_bank_statement_import_fr_cfonb
• account_banking_fr_lcr
• l10n_fr_account_tax_unece
• l10n_fr_department
• l10n_fr_department_oversea
• l10n_fr_intrastat_product
• l10n_fr_intrastat_service
• l10n_fr_naf_ape - By @cvinh - #324
• l10n_fr_siret by #252
• l10n_fr_state

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

Hi there ! quite a long time I haven't contribute to OCA, I'm back to maintain some odoo projects !

I would like to purpose a new module l10n_fr_city based on base_address_city module
that would periodically sync data from La Poste

So installing this module would mark enforce_cities on res.company to True for Frane

I expect to definie a cron job once a month (this dataset is bi-annual) and
I hope to be able to easly detect new dataset to only compute if needs.
The whole dataset is about 16Mo in json format.

I'll probably use the csv file format if possible with the odoo import system
to using the external id mechanism to keep in sync records.

I'd like to keep information from La Poste to let other developer be able
to use it so I suggest the following mapping:

Is it the right repo to address this module ?
Is there already such effort ?
Do you have better naming field to suggest ?
I'm wondering what's the best field to manager GPS coordinate ? I would like to
avoid that this modul depends from postGIS postgresql plugin.

Any reactions are welcome
I expect to develop that by the beginning of 2021.

I'll renew my OCA cotisation in the mean time ;)

Hello,

I created a new projet (v13) on Odoo.sh with nothing (no production or staging branch, no customization. Only a dev branch Main)
From the LCR form, i clicked on button "Deploy on Odoo.sh"
it created a new development branch named : app-account_banking_fr_lcr

But i obtained lors of errors that you can see in the file attached
Errors_20210831.txt

Could you help me to fix these problems ?
Vincent

It could be nice to add the filter/group in leads application (so as to filter or group lead by department).

Is there any chance that we can get a module DSN into oca. Openconcerto seems to get one and I think we should have it.

As I'm not sure how to start I've posted my thought here.

Thank for replying.

It would be great if we could split a bit l10n_fr_siret to remove the dependency on account.

We have one customer at least who would like to record a SIRET number on partners but does not wish to pay an Enterprise Contract for accounting which he is not going to use.

Hello,
i downloaded module "French letter of change", added in my local code and then push it on Odoo.sh (development branch)
My project on odoo.sh is in version 13 (latest version)
I obtained many errors (see txt file attached)

Is somenone could explain to me what's happen ?

Regards
Vincent

Errors.txt

If I have two identical lines in a CFONB file, I cannot import it. It is a real use case I found, with two real wire transfers done the same day.

The reason comes from:

'unique_import_id':
'%s-%s-%.2f-%s' % (date_str, ref, amount, name),

In case that you have an existing db, and you install the module.
The module replace the existing siret with a computed field without any value inside.
We need to do a pre/post migration script

Hi,

I can't import CFONB120 file (see attached) with XPF currency. I get the following message : Pas de devise trouvée correspondant à 'XPF'. Module : account_bank_statement_import_fr_cfonb
Please advise

Best Regards,

extrait_20171030.txt

This seems to be related to odoo#9708

I checked in https://travis-ci.org/gurneyalex/l10n-france/builds/97396540 that @rco-odoo's patch in odoo/odoo#9896 fixes the situation and proposed to port that fix in OCA/OCB#404 to at least get a clean situation on OCB.

Context :
OCB 13.0 Odoo Server up to date [(07/11/2020),] on Virgin database , to reproduce issue faced on my test environnement.
Get bug, also on runbot : http://3430748-13-0-06e23c.runbot2.odoo-community.org/

Steps to reproduce :
Check module dependancy, (account_tax_unece & l10n_fr ). Considering that "auto_installable": True, have not effect on this module, then,
Try to Install the module : "l10n_fr_account_tax_unece" module
So, now, you see bug tracking message.

Odoo Server Error :

Traceback (most recent call last):
  File "/opt/odoo/odoo_v13/server/odoo/tools/convert.py", line 712, in parse
    self._tag_root(de)
  File "/opt/odoo/odoo_v13/server/odoo/tools/convert.py", line 674, in _tag_root
    f(rec)
  File "/opt/odoo/odoo_v13/server/odoo/tools/convert.py", line 527, in _tag_record
    raise Exception("Cannot update missing record %r" % xid)
  Exception: Cannot update missing record 'l10n_fr.tva_acq_intra_normale'

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
.../...
File "/opt/odoo/odoo_v13/server/odoo/tools/convert.py", line 527, in _tag_record
    raise Exception("Cannot update missing record %r" % xid)
odoo.tools.convert.ParseError: "Cannot update missing record 'l10n_fr.tva_acq_intra_normale'" while parsing /opt/odoo/odoo_v13/oca_addons/l10n_fr_account_tax_unece/data/account_tax_template.xml:7, near
<odoo>
    <!-- 20.0 -->
    <record id="l10n_fr.tva_normale" model="account.tax.template">
        <field name="unece_type_id" ref="account_tax_unece.tax_type_vat"/>
        <field name="unece_categ_id" ref="account_tax_unece.tax_categ_s"/>
        <field name="unece_due_date_id" ref="account_tax_unece.date_5"/>
    </record>
    <!-- 20.0-TTC -->

@alexis-via Thanks in advance for your help.
.

I have a difficult bug on l10n_fr_siret in multi-company environnement. It's an old bug ; I have it since the beginning on one of my projects that went to production on 1/1/2015 in a multi-company environnement, but I didn't report it at the time.

In certain very particular conditions that I still don't identify properly, you get this kind of error message when you register a payment manually on a customer invoice via the button "Register payment":

L'opération demandée ne peut pas être effectuée en raison de la politique de sécurité. Veuillez contacter votre administrateur système. Type de document: res.company. Opération: read.

The bug seems linked to the field 'siret' on res.company, which is a related field with Store=True. There are some problems with these related field on objets with a multi-company record-rule that are related to an object which is not company-specific. In this case:

• the 'siret' field on res.company is a field related='partner_id.siret' and store=True field
• there is a record rule on res.company
• res.partner doesn't have any multi-company record rule
  This kind of things raises some issues in multi-company environements: odoo/odoo#9450

And the problems also seems to be linked to the sync of fields from contact to company, cf
https://github.com/OCA/l10n-france/blob/8.0/l10n_fr_siret/partner.py#L85

My workaround for this bug for the moment is to disable the inherit of the method "_commercial_fields".

This bug is very difficult to reproduce, but, when you find an invoice that has the bug when you register a payment, then it becomes 100% reproductible.

Hi,

I try a fresh odoo 10 install (on debian 8)
with l10n-france and chorus account (branch 10)

When I try to validate an invoice I get this error :

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/odoo/http.py", line 642, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/usr/lib/python2.7/dist-packages/odoo/http.py", line 684, in dispatch
    result = self._call_function(**self.params)
  File "/usr/lib/python2.7/dist-packages/odoo/http.py", line 334, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/odoo/service/model.py", line 101, in wrapper
    return f(dbname, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/odoo/http.py", line 327, in checked_call
    result = self.endpoint(*a, **kw)
  File "/usr/lib/python2.7/dist-packages/odoo/http.py", line 942, in __call__
    return self.method(*args, **kw)
  File "/usr/lib/python2.7/dist-packages/odoo/http.py", line 507, in response_wrap
    response = f(*args, **kw)
  File "/usr/lib/python2.7/dist-packages/odoo/addons/web/controllers/main.py", line 899, in call_button
    action = self._call_kw(model, method, args, {})
  File "/usr/lib/python2.7/dist-packages/odoo/addons/web/controllers/main.py", line 887, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/usr/lib/python2.7/dist-packages/odoo/api.py", line 689, in call_kw
    return call_kw_multi(method, model, args, kwargs)
  File "/usr/lib/python2.7/dist-packages/odoo/api.py", line 680, in call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/odoo/addons/account/models/account_invoice.py", line 587, in action_invoice_open
    to_open_invoices.action_move_create()
  File "/usr/lib/python2.7/dist-packages/odoo/addons/l10n_fr_chorus_account/models/account_invoice.py", line 89, in action_move_create
    if not self.payment_mode_id:
AttributeError: 'account.invoice' object has no attribute 'payment_mode_id'

I don't find any clue how to solve this.
Maybe I have a plugin missing ? so there is a dependency error ?
Thank you

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0

Modules to migrate

• account_bank_statement_import_fr_cfonb
• account_banking_fr_lcr
• l10n_fr_account_fiscal_position_rule
• l10n_fr_base_location_geonames_import
• l10n_fr_department
• l10n_fr_department_delivery
• l10n_fr_department_oversea
• l10n_fr_fec
• l10n_fr_naf_ape
• l10n_fr_siret
• l10n_fr_state

l10n_fr_siret was accepted in account-financial-tools but now that we have this l10n repo, it would be better suited here.

Module

l10n_fr_siret

Describe the bug

A clear and concise description of what the bug is.

To Reproduce

Affected versions = v.14:

Steps to reproduce the behavior:

1. A company is created with SIREN 000000000 and NIC 00000; (because we don't have immediately the information)
2. A company's contact is created (which will inherit the SIREN and NIC from the company)
3. The company's SIREN and NIC are changed (to 378234595 and 00072);
4. The SIREN is passed down to the contact, but the NIC is not!
5. The contact SIRET is now 37823459500000 (because it inherits the parent's SIREN, but it keeps the old NIC), which is a faulty code.

Expected behavior
The change should be taken into account for the company and for the contact who is not a company is an another NIC

Additional context

I proposed a module to manage french ecotax in v8 : #76

After discussion with @alexis-via, we propose to make this enhancement for 10.0.

Context :

Definition of ecotax :
An Ecotax (short for ecological taxation) is a tax levied on activities which are considered to be harmful to the environment and is intended to promote environmentally friendly activities via economic incentives (source https://en.wikipedia.org/wiki/Ecotax).

There are 2 levels to manage ecotax :

1. basic level : consider the sale ecotax as a field of the product (fields.Float()).

This field should be displayed on the invoice lines (sale line and purchase line) ("included ecotax amount").
The price of the product should include ecotax . For exemple if the original product price = 100€ and ecotax = 1€ product price should be update to 101€.
Then add a function field on account.invoice named "total_ecotax_amount".
The total ecotax amount is the sum of ecotax amount line.
This field "total_ecotax_amount" should be displayed on the invoice (sale, purchase).

To declare and transfer to the ecotax company, you can simply use the BI features on invoices to get the sale ecotax amounts.

2. Advanced level : consider ecotax as a regular tax : like in PR #76 (module used in production for an akretion customer)

consider ecotax as a regular tax. We can use separate accountant account for ecotax.
The goal is not to have one tax for each amount, but one tax for all amounts. Then, the amount of tax (in account.tax) are computed by using python code (value taken from product ).
ecotax must have a sequence lower than VAT tax and must be included in tax.

To make this we should add :

• new type of account.tax,

• a field on product that contains ecotaxe value of product (or computed value for weight base ecotax),

• set the new taxes (ecotaxe) on product,

• a computed field on invoice (sale, purchase) line that display ecotax,

• a total mount ecotax field on invoice (sale and purchase)

  In this feature we also manage a weight based ecotax (For furnitures (desk, table, wardrobe, ...)).
  To simplify handling weight based ecotax, we should add an ecotax classification object. This object contains different rates applied on based weight ecotax as well as different fixed ecotax amounts (classification may be : "fixed" or "weight based"). It also contains taxes used to compute ecotax amounts.
  With this approach, you have a separate accounting account for the ecotax, so you can directly know in the accounting how much you have to transfer to the ecotax company.

Solution proposed :

So, we propose to make 2 modules :
1- l10n_fr_base_ecotax
2- l10n_fr_advance_ecotax

the advance module inherits form the base module.

Features:

Base module

• Fixed ecotax only (a field on product)
• ecotax amount on sale line, purchase line and invoice line (for display purpose because de ecotax amount are include in the price of product in the basic approach)
• Total ecotax amount on sale, purchase and invoice
• Value off ecotax are propagated to invoice from sale or purchase order.

Advanced module

• Fixed and weight based ecotax,
• ecotax classification to factorise value (several product has the same rate)
• use account.tax to compute ecotax and define an accountant account (product price don’t contains ecotax):
  Type = 'code' ; python code contain this :
  ** result = product.fixed_ecotax or 0.0 (for tax used for fixed ecotax ; Account ex : sale ecotax 707110, purchase ecotax 607110 )
  ** result = product.computed_ecotax or 0.0 (for tax used for fweight based ecotxe; Account ex : sale ecotax 707120, purchase ecotax 607120)
  ** Include_base_amount = True
  ** Sequence less then VAT tax (ex 0)
  ** Add a field, is_ecotax = True
• Sale, purchase, and invoice line contain a computed field that compute ecotax by using taxes (with is_ecotax = true).

Design:

Base module

• Add a field fixed_ecotax = fields.Float to product_product.
• Display this field on the invoice line (sale line and purchase line) ("included ecotax amount"),
• Add a function field on account.invoice named "total_ecotax_amount". that is computed with :
• Add total_ecotax

total_ecotax = 0.0
for l in line:
total_ecotax += l.quantity * l.product_id.ecotax_amount
self.total_ecotax_amount = total_ecotax

• Display the field "total_ecotax_amount" on the invoice (sale, purchase).

Advanced module

• Manage fixed (ex electronic devices) and a weight based ecotax (For furnitures (desk, table, wardrobe, ...))
• Add an object ecotax classification that contains ecotax amount or rate to apply for weight (type = fixed, or weight based)
• On product product :
  • add a link to ecotax classification,
  • add computed field that compute value by using ecotax classification.
• Add a field is_ecotax on account.tax.
• The ecotax must be defined as python code :
  ecotax must have a sequence lower then VAT tax and must be included in tax.
• The sale ecotax as a property of the product (fields.Float(company_dependant=True)).
• The amount of tax (in account.tax) are computed by using type python code ( use module account_tax_python)
• Add computed field on invoice (sale, purchase) line that display the total Amount ecotax.

Use Case:

• ecological taxation called ecotax in France
• Eco contribution (wieght based tax) in France

Proposal for module name :

• l10n_fr_base_ecotax
• l10n_fr_advance_ecotax

The project https://github.com/OCA/community-data-files currently contains 2 modules that are localization-related, so it has been suggested they should be moved to other existing l10n_* projects.

Odoo 14 (latest). When trying to use the API to find the SIREN number for a company, I get an error.

Module

l10n_fr_siret_lookup

Describe the bug

Erreur:
Odoo Server Error

Traceback (most recent call last):
File "/opt/bitnami/odoo/lib/odoo-14.0.post20220110-py3.8.egg/odoo/addons/base/models/ir_http.py", line 237, in _dispatch
result = request.dispatch()
File "/opt/bitnami/odoo/lib/odoo-14.0.post20220110-py3.8.egg/odoo/http.py", line 684, in dispatch
result = self._call_function(**self.params)
File "/opt/bitnami/odoo/lib/odoo-14.0.post20220110-py3.8.egg/odoo/http.py", line 360, in _call_function
return checked_call(self.db, *args, **kwargs)
File "/opt/bitnami/odoo/lib/odoo-14.0.post20220110-py3.8.egg/odoo/service/model.py", line 94, in wrapper
return f(dbname, *args, **kwargs)
File "/opt/bitnami/odoo/lib/odoo-14.0.post20220110-py3.8.egg/odoo/http.py", line 348, in checked_call
result = self.endpoint(*a, **kw)
File "/opt/bitnami/odoo/lib/odoo-14.0.post20220110-py3.8.egg/odoo/http.py", line 913, in call
return self.method(*args, **kw)
File "/opt/bitnami/odoo/lib/odoo-14.0.post20220110-py3.8.egg/odoo/http.py", line 532, in response_wrap
response = f(*args, **kw)
File "/opt/bitnami/odoo/lib/odoo-14.0.post20220110-py3.8.egg/odoo/addons/web/controllers/main.py", line 1396, in call_button
action = self._call_kw(model, method, args, kwargs)
File "/opt/bitnami/odoo/lib/odoo-14.0.post20220110-py3.8.egg/odoo/addons/web/controllers/main.py", line 1384, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/opt/bitnami/odoo/lib/odoo-14.0.post20220110-py3.8.egg/odoo/api.py", line 399, in call_kw
result = _call_kw_multi(method, model, args, kwargs)
File "/opt/bitnami/odoo/lib/odoo-14.0.post20220110-py3.8.egg/odoo/api.py", line 386, in _call_kw_multi
result = method(recs, *args, **kwargs)
File "/opt/bitnami/odoo-enterprise/l10n_fr_siret_lookup/wizard/fr_siret_lookup.py", line 76, in get_lines
res = self._prepare_partner_from_data(company["fields"])
File "/opt/bitnami/odoo-enterprise/l10n_fr_siret_lookup/wizard/fr_siret_lookup.py", line 46, in _prepare_partner_from_data
country_id = self.env["res.partner"]._opendatasoft_dpt2country(
File "/opt/bitnami/odoo-enterprise/l10n_fr_siret_lookup/models/res_partner.py", line 156, in _opendatasoft_dpt2country
if dpt_code and len(dpt_code) == 2:
Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
File "/opt/bitnami/odoo/lib/odoo-14.0.post20220110-py3.8.egg/odoo/http.py", line 640, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/opt/bitnami/odoo/lib/odoo-14.0.post20220110-py3.8.egg/odoo/http.py", line 316, in _handle_exception
raise exception.with_traceback(None) from new_cause
TypeError: object of type 'int' has no len()

To Reproduce

Affected versions:

• Odoo 14.0+e-20220110 (Enterprise Edition)
• Module : latest published on https://apps.odoo.com/apps/modules/14.0/l10n_fr_siret_lookup/

Steps to reproduce the behavior:

1. Installed the two modules : l10n_fr_siret & l10n_fr_siret_lookup
2. Open a company in Contacts, Action > search API SIRENE
3. In the new dialogue , click on search
4. An error window appears.

Expected behavior
The action has to produce suggestions of SIRET nubers

Additional context
Add any other context about the problem here. (e.g. OS, Python version, ...)

Hi @alexis-via , hi everyone.

Hope you're doing well.
I was wondering if the module l10n_fr_ecotaxe still have an interest in v14?
If it's covered by the Odoo core now I will appreciate any advice on how to configure properly the taxes to achieve the same behaviour as the ones provided by your module.

Thanks for the time spent on reading.

regards

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

Modules to migrate

• account_balance_ebp_csv_export
• account_banking_fr_lcr
• account_statement_import_fr_cfonb
• l10n_fr_account_invoice_import_facturx
• l10n_fr_account_tax_unece
• l10n_fr_business_document_import
• l10n_fr_cog
• l10n_fr_das2
• l10n_fr_department
• l10n_fr_department_oversea
• l10n_fr_fec_oca
• l10n_fr_hr_check_ssnid
• l10n_fr_hr_rup
• l10n_fr_intrastat_product
• l10n_fr_intrastat_service
• l10n_fr_mis_reports
• l10n_fr_siret
• l10n_fr_state

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0

Modules to migrate

• account_bank_statement_import_fr_cfonb
• account_banking_fr_lcr
• l10n_fr_account_fiscal_position_rule
• l10n_fr_account_tax_unece
• l10n_fr_base_location_geonames_import
• l10n_fr_business_document_import
• l10n_fr_department
• l10n_fr_department_delivery
• l10n_fr_department_oversea
• l10n_fr_intrastat_product
• l10n_fr_intrastat_service
• l10n_fr_naf_ape
• l10n_fr_siret
• l10n_fr_state

Do we really need report_aeroo to generate CSV?

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0

Modules to migrate

• l10n_fr_base_location_geonames_import
• l10n_fr_naf_ape
• l10n_fr_siret
• l10n_fr_department
• account_bank_statement_import_fr_cfonb
• l10n_fr_department_delivery
• l10n_fr_state
• l10n_fr_fec
• l10n_fr_account_fiscal_position_rule
• account_banking_fr_lcr
• l10n_fr_tax_sale_ttc

Using the V13 module account_banking_fr_lcr I can generate an LCR txt file to be sent to the bank and that will set the corresponding invoices to PAID but when I register the bank statement I cannot reconcile it with the payment because it is not there
I'm using this module in an OE 13 context

Maurice

In file models/partner.py

if rec.nic and not _check_luhn(rec.siren + rec.nic):
                    return UserError(
                        _("The SIRET '%s%s' is invalid: "
                          "the checksum is wrong.")
                        % (rec.siren, rec.nic))

Should be replaced by:

if rec.nic and not _check_luhn(rec.siren + rec.nic):
                    raise UserError(
                        _("The SIRET '%s%s' is invalid: "
                          "the checksum is wrong.")
                        % (rec.siren, rec.nic))

Corsica has 2 departments, with code 2A and 2B, but the zipcodes start with '20' -> they are not matched correctly, and we need a special case for these 2 departments.

Reference:

• https://www.annuaire-administration.com/code-postal/departement/corse-du-sud.html
• https://www.annuaire-administration.com/code-postal/departement/haute-corse.html

Dear Community,

I would like to start a thread regarding the SAPIN french law. From now the french administration is not really explicit about the ways to certify the Odoo solution. Does anyone has some legal info?

Here are some of the resources I found :

• http://revuefiduciaire.grouperf.com/article/3661/hb/20160919173548859.html
• https://www.april.org/point-detape-sur-la-nouvelle-reglementation-des-logiciels-de-gestion-et-de-comptabilite

Some part of the law seems to be easy to certify : Hosting / Backup / Recovery are easy for the community partners to be certified.

Regarding the durability of the datas I think we have a problem with the POS. From now the POS has been designed to be working without network and all the datas are stored inside the browser database. This point could be an issue if you consider how easy it is to get the datas from the internal database (and what about the debug mode allowing to flush the orders!!!)
I have some little ideas on those points :

• Find a way to block some inappropriate operation from the POS (like in debug mode)
• Find a way to store every transaction in the POSBox from the POS
• Find a way to protect the browser database with encryption
• Find a way to deliver browser application with options preventing the user from acceding to the internal database.

None of those solutions looks enough for me(everything in the client part could be changed by an experienced user/ ethic hacker).

Odoo seems to have started a reflexion on this : https://github.com/odoo-dev/odoo/commits/9.0-l10n_fr-certification-lpe . It looks like Odoo is considering that only the account_cancel module could be a problem.

Some partners have started a reflexion, (BTW thanks to Sébastien Morelle) : https://anybox.fr/blog/logiciels-de-caisse-certifies

Maybe we could start a thread here https://odoo-community.org/groups/france-24

Any feedback would be appreciated.

Regards

Currently, Travis is red on l10n-france branch 10.0 because of the test of hr_holidays_jours_ouvrables, cf https://travis-ci.org/OCA/l10n-france/jobs/436563319

@guewen AFAIK, you are the author of that module: could you have a look at this ?

Readme of base_location_geonames_import should mention Python unidecode as a dependency
(pip install unidecode)

The text is will be in french, because it is an issue for only french company.
author of l10n_fr_fec : @alexis-via

Bonjour

Suite à l'intervention de notre expert comptable il est apparue quelque questions, améliorations, afin d'être en conformité avec la loi. https://www.legifrance.gouv.fr/eli/arrete/2013/7/29/BUDE1315492A/jo/texte

• L'article 2, impose de fournir une description incluant :
  « 1° Le nom, la nature et la signification de chaque zone ; « 2° La signification des codes utilisés comme valeurs de zone ; « 3° Toutes les informations techniques nécessaires au traitement des fichiers, et notamment le jeu de caractères utilisé, le type de structure, la longueur des enregistrements, les caractères séparateur de zone et séparateur d'enregistrement.
  La creation d'un PDF incluant notamment la ligne 3°, à télécharger depuis le wizard serait un début de solution.
• Les expert-comptables ont un nouveau logiciel de verification de FEC sous la forme de macro VBA, qui a des problèmes de lecture si il y a des tabulations dans les champs, il doit prendre en compte les deux délimiteurs tab et pipe sur le même fichier. Dans le script Odoo est-il possible de faire en sorte que les tabulations soient supprimées.
• Notre experts comptable ne peut pas importer le FEC dans son logiciel d'analyse, car les comptes auxiliaires sont indiqués sur tout les comptes, alors que d'après notre expert, il ne devrait être que sur les 401, 411. D'après la loi il n'est explicitement indiqué les comptes à exclure (ou à inclure) d'avoir un compte auxiliaire. Afin de faciliter le travail de ces derniers, le rajout d'un champs des comptes avec compte auxiliaires dans le wizard serait-il possible ? Dans l'exemple de ce document seul les comptes 401,411 sont montrés : http://bofip.impots.gouv.fr/bofip/ext/pdf/createPdfWithAnnexePermalien/BOI-CF-IOR-60-40-20-20131213.pdf?doc=9028-PGP&identifiant=BOI-CF-IOR-60-40-20-20131213
• La date de lettrage indiqué dans Odoo est celle du jour où est réalisé le lettrage. Or cette note http://www.suiteexpert.fr/public/documents/awcompta/A47_AnnexeTechnique.pdf, serait plutôt d'avis a indiquer la date du plus vieux mouvement. Qu'en pensez-vous ?

Is there a case where would not want the siren to be unique?

what would be the best way to implement it knowing that some partners could have no siren?
thank you

hello @alexis-via

you ported account_bank_statement_import_fr_cfonb to v9, but there are some dependencies (account_bank_statement_import) which are not yet ported to v9. I could not find a PR in https://github.com/OCA/bank-statement-import making that module available. Do you have a branch somewhere with this port available you could propose for merge?

Thanks for your time and contributions to the OCA.

When you do -u l10n_fr_department on a database that has a lot of partners, it will stay A LOT of time on loading l10n_fr_department/data/res_country_department_data.yml:

2015-01-20 22:09:39,330 6410 INFO o8_barroux8 openerp.modules.module: module l10n_fr_department: creating or updating database tables
2015-01-20 22:09:39,679 6410 INFO o8_barroux8 openerp.modules.loading: loading l10n_fr_department/security/ir_model_access.yml
2015-01-20 22:09:39,775 6410 INFO o8_barroux8 openerp.modules.loading: loading l10n_fr_department/data/res_country_department_data.yml
[here, it stays a VERY VERY long  time]

I think it is linked to the invalidation of the field department_id on res.partner.
In order to solve this issue, the only solution I found is to comment out the following 2 lines in res_partner.py, in the store= argument of the definition of the department_id field:

#                'res.country.department': (
#                    _get_partner_from_department, ['code', 'state_id'], 20),

I noticed that the departments are stored in an YML file (data/res_country_department_data.yml) and I don't know what's the policy about noupdate in .yml files.

I'd like to keep the department_id as a stored field, in order to be able to use it in BI.

Hi, I've discovered this useful plugin (thank you!) and I'm trying it on my v12 setup but I've noticed some of my invoice lines are not included when I click on the 'Generate lines from invoices' button.

Looking at the code, it looks like only lines including a product are processed. In my case, I can have invoice lines including eveything except a product.

Do you confirm this behaviour?

Hi all,

Travis Status

• Travis is red on 8.0, 9.0, 10.0, 12.0, 13.0, 14.0 branches. (since monthes / years)
• Travis is green on 11.0 (maybe because there are only 5 modules ;-))

Runbot Status

• runbot is red on 12.0 and 14.0
• runbot is green on 10.0 and 13.0
• runbot is anavailable for 11.0

That is quite problematic, mainly because all the contribution PRs are so red, even if there are valid. Included trivial ones. (see)

The work to make all the branch green is big, and trying to fix a problems raise other problems. see : #286 by @ivantodorovich.
flake8 / pylint / pre-commit issues ; no references to oca repositories ; trouble in python lib ; other errors ; ...

To go ahead, I so quick-fixed

• 12.0 (because that the branch I'm working on). excluding 6 modules.
• 14.0 (because that is the "head" branch"). excluding 10 modules.

• on 12.0 and 14.0, I disabled many modules in the .travis.yml file. (EXCLUDE syntax)
• on 14.0, I also excluded many modules in the .pre-commit-config.yaml file.
• For all that modules, I set the development_status key to Alpha

So CI is now green, and it should stay green !

However, it is not respecting OCA guidelines. (even for alpha modules, see oca conventions)

I don't know how to continue in the good way.

• we keep as it, excluding most of the modules.
• we fix the branch. (at least the 14.0 one). @alexis-via : if you want help to understand new OCA quality tools and checks, please ping me, we can work on that topic.

In the meantime :

• please stop merge without ocabot command, as it will make the repo red again.
• you will soon be able to use the ocabot rebase for your PR against 12.0 and 14.0 branches.

CC : recent contributors : @alexis-via, @kevinkhao, @bealdav, @ivantodorovich

CC : OCA quality-tools maintainers : @sbidoul, @pedrobaeza

After installation of Import French CFONB Bank Statements, when importing a file whe have error
Any idea what's happening ?
Erreur:
Odoo Server Error

Traceback (most recent call last):
File "/home/odoo/src/odoo/odoo/addons/base/models/ir_http.py", line 237, in _dispatch
result = request.dispatch()
File "/home/odoo/src/odoo/odoo/http.py", line 683, in dispatch
result = self._call_function(**self.params)
File "/home/odoo/src/odoo/odoo/http.py", line 359, in _call_function
return checked_call(self.db, *args, **kwargs)
File "/home/odoo/src/odoo/odoo/service/model.py", line 94, in wrapper
return f(dbname, *args, **kwargs)
File "/home/odoo/src/odoo/odoo/http.py", line 347, in checked_call
result = self.endpoint(*a, **kw)
File "/home/odoo/src/odoo/odoo/http.py", line 912, in call
return self.method(*args, **kw)
File "/home/odoo/src/odoo/odoo/http.py", line 531, in response_wrap
response = f(*args, **kw)
File "/home/odoo/src/odoo/addons/web/controllers/main.py", line 1393, in call_button
action = self._call_kw(model, method, args, kwargs)
File "/home/odoo/src/odoo/addons/web/controllers/main.py", line 1381, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/home/odoo/src/odoo/odoo/api.py", line 396, in call_kw
result = _call_kw_multi(method, model, args, kwargs)
File "/home/odoo/src/odoo/odoo/api.py", line 383, in _call_kw_multi
result = method(recs, *args, **kwargs)
File "/home/odoo/src/enterprise/account_bank_statement_import/account_bank_statement_import.py", line 53, in import_file
statement_ids, statement_line_ids, notifications = self._create_bank_statements(stmts_vals)
File "/home/odoo/src/enterprise/account_bank_statement_import/account_bank_statement_import.py", line 270, in _create_bank_statements
statement = BankStatement.create(st_vals)
File "", line 2, in create
File "/home/odoo/src/odoo/odoo/api.py", line 344, in _model_create_multi
return create(self, [arg])
File "/home/odoo/src/odoo/addons/account/models/account_bank_statement.py", line 275, in create
res = super(AccountBankStatement, self).create(values)
File "", line 2, in create
File "/home/odoo/src/odoo/odoo/api.py", line 345, in _model_create_multi
return create(self, arg)
File "/home/odoo/src/odoo/addons/mail/models/mail_thread.py", line 264, in create
threads = super(MailThread, self).create(vals_list)
File "", line 2, in create
File "/home/odoo/src/odoo/odoo/api.py", line 345, in _model_create_multi
return create(self, arg)
File "/home/odoo/src/odoo/odoo/addons/base/models/ir_fields.py", line 533, in create
recs = super().create(vals_list)
File "", line 2, in create
File "/home/odoo/src/odoo/odoo/api.py", line 345, in _model_create_multi
return create(self, arg)
File "/home/odoo/src/odoo/odoo/models.py", line 3868, in create
records = self._create(data_list)
File "/home/odoo/src/odoo/odoo/models.py", line 4026, in _create
field.create([
File "/home/odoo/src/odoo/odoo/fields.py", line 3041, in create
self.write_batch(record_values, True)
File "/home/odoo/src/odoo/odoo/fields.py", line 3067, in write_batch
return self.write_real(records_commands_list, create)
File "/home/odoo/src/odoo/odoo/fields.py", line 3239, in write_real
flush()
File "/home/odoo/src/odoo/odoo/fields.py", line 3203, in flush
comodel.create(to_create)
File "", line 2, in create
File "/home/odoo/src/odoo/odoo/api.py", line 345, in _model_create_multi
return create(self, arg)
File "/home/odoo/src/odoo/addons/account/models/account_bank_statement.py", line 858, in create
st_lines = super().create(vals_list)
File "", line 2, in create
File "/home/odoo/src/odoo/odoo/api.py", line 345, in _model_create_multi
return create(self, arg)
File "/home/odoo/src/odoo/odoo/addons/base/models/ir_fields.py", line 533, in create
recs = super().create(vals_list)
File "", line 2, in create
File "/home/odoo/src/odoo/odoo/api.py", line 345, in _model_create_multi
return create(self, arg)
File "/home/odoo/src/odoo/odoo/models.py", line 3825, in create
raise ValueError("Invalid field %r on model %r" % (key, self._name))
Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
File "/home/odoo/src/odoo/odoo/http.py", line 639, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/home/odoo/src/odoo/odoo/http.py", line 315, in _handle_exception
raise exception.with_traceback(None) from new_cause
ValueError: Invalid field 'note' on model 'account.bank.statement.line'