Comments (4)
The issue happens at the last step
Here, when changing the delivery method, the method _update_website_sale_delivery
should be triggered by this JS code.
But when the customer is allowed to skip_payment, the JS code throws an error at this line :
Uncaught TypeError:
``$pay_button.data(...) is undefined
_onCarrierClick http://localhost:8012/web/content/985-5287018/1/web.assets_frontend.js:295
so the method is not tiggered, the carrier is not updated, and the first one on the list is used.
I think this might be because the payment route is skipped and we go directly to the confirmation route (like below).
However I don't have a clearer idea.
@sergio-teruel Do you know a way to fix this issue ?
from e-commerce.
Sorry @victor-champonnois The website_sale_checkout_skip_payment module has not include any JS code, so I think that this error is related to other module...
from e-commerce.
@sergio-teruel I took a look and it seems to be related to the absence of the payment button element. https://github.com/odoo/odoo/blob/c53081f10befd4f1c98e46a450ed3bc71a6246ed/addons/website_sale_delivery/static/src/js/website_sale_delivery.js#L12
Anyway, I couldn't reproduce the bug in the versions we're currently supporting for our customers (>13).
So @victor-champonnois feel free to propose a PR patching de issue for 12.0
from e-commerce.
There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.
from e-commerce.
Related Issues (20)
- website_sale_stock_available error message for missing field HOT 5
- 15c website_sale_hide_price variant price seen HOT 2
- website_sale_checkout_country_vat HOT 1
- [13] website_sale_hide_price ---> hide prices at variant level HOT 1
- Migration to version 16.0 HOT 14
- Website_sale_hide_price: hidden price message HOT 2
- uom
- [website_sale_invoice_address] - display billing address as "billing" in checkout HOT 2
- [14.0] website_sale_cart_expire HOT 1
- [website_sale_stock_available] Module depens on "stock_available" but module isn't available in ODOO16 HOT 1
- 'website_sale_filter_product_brand' slow /shop loading time HOT 1
- Get an error when installing the module HOT 3
- [16.0] website_sale_hide_price HOT 2
- Edit function in Webshop does not work HOT 1
- Price visible in search HOT 2
- Error using dynamic content products (block) when using a catergory where all the products are unpublished HOT 6
- website_sale_hide_price 16.0.1.3.0 can't be upgraded over 16.0.1.2.1 HOT 2
- Variant error when module is installed. HOT 3
- [16.0] website_sale_hide_price - Show price in comparison tool and wishlist HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from e-commerce.