Questions on package_ids about delivery-carrier

[guewen]

Hi,

The use case is: you want to generate labels for only some of the packages of a picking, and generate labels for the remaining packages later.

The API has changed a bit since, but in 7.0 it was used here: https://github.com/OCA/carrier-delivery/blob/467c5cc2d60c43b1ef3037ae6b83d375b99d3b72/delivery_carrier_label_dispatch/wizard/generate_labels.py#L108-L111 (it generates the labels of the packages which are in the picking dispatch only).

[hparfr]

Thanks for this answer.

In the code you refere, you have always 1 picking and 0 or 1 pack.
But it can lead to issues if there is call with 2 pickings and 1 pack.

[guewen]

I see your point, is it something that might happen? having a package cross-pickings? If yes, then yes it should be handled better...

[hparfr]

In terms of code quality, it's always better if the API is obvious or well documented for starters like me.

About the business cases :

• a package cross-picking -> we have this need for some of our clients. They have customer who buys on a regulary basis, and they want put in the same package goods from differents sale orders.
• multiple package for one picking -> never encoutered yet, but I was thinking of this use case when you want different levels of services (insurance, urgent, fragile, voluminous) for the same order.
  Like part of the sale order by aircraft for the small items and the rest by cargo.