Coder Social home page Coder Social logo

Comments (13)

bealdav avatar bealdav commented on July 17, 2024

About 1. I propose to implement the same as that
https://github.com/OCA/server-env/blob/12.0/mail_environment/models/ir_mail_server.py
but for carrier.account . What do you think @yvaucher ? Can I make a PR on #187 ?

from delivery-carrier.

pedrobaeza avatar pedrobaeza commented on July 17, 2024

Please don't depend on all the *_environment stuff.

from delivery-carrier.

bealdav avatar bealdav commented on July 17, 2024

In the whole ERP we need a good solution to manage credentials of external accounts. At Akretion we decided to use keychain (a version modified in v12) which itself based on server environment tools. C2C (and others) use server env only.

Please @pedrobaeza could you precise what is your generic option to deal with external credential accounts in the whole erp ? Thanks

from delivery-carrier.

pedrobaeza avatar pedrobaeza commented on July 17, 2024

You were talking about *_environment, not keychain. That's why I told you about not using that. keychain is good for keeping some secrets.

from delivery-carrier.

florian-dacosta avatar florian-dacosta commented on July 17, 2024

I guess the *_environment part can be put in a submodule then.

from delivery-carrier.

bealdav avatar bealdav commented on July 17, 2024

That's OK for me to add another module.
OCA/server-env#22

from delivery-carrier.

bealdav avatar bealdav commented on July 17, 2024
  1. @yvaucher @guewen @damdam-s are you open to modify base_delivery_label to avoid to deliver without package ?

from delivery-carrier.

yvaucher avatar yvaucher commented on July 17, 2024

@bealdav about your question on delivery without package. And following the call we had.

We might have some little things to tweak on the OCA/rma modules when returning goods. Nevertheless, it would make indeed more sense if we rely on pack only and not consider on itself picking as a pack.
And we could enforce the creation of a pack if we print a label.

So let's go for labels generation only with packs.

One question about it, though. Do you still want a merged pdf of the labels on the picking? Or do you plan to have attachment only linked to the packages.

from delivery-carrier.

bealdav avatar bealdav commented on July 17, 2024

@yvaucher thanks for your reply.

For labels, there several solutions. The easiest seems to be to provide a tree view of packages with an action from picking. Then selecting all records of the tree view you get all files in one click.

Duplicate info in picking is also possible with merged document.

from delivery-carrier.

angelmoya avatar angelmoya commented on July 17, 2024

There are not usual, but some users don't use packages, and want to use delivery carrier integration, in some ecommerce arround 90% of sales has only 1 product.

Picking has delivery address, and we can put tracking code on it to be shown to customer on portal.

On the other hand, now I ned to create parcel for more than one picking, to send only one package for two sales... in this project we have more then one sale order in the morning, and we send together.

A generic module to account could be great, on sprint code @jctrey is working on modules to get the tracking link for each carrier, and can use that as dependency.

Maybe we can merge #187 and then we can prepare this base module.

from delivery-carrier.

bealdav avatar bealdav commented on July 17, 2024

Ok @angelmoya

1/ Our goal is to make user experience as easy as possible and make code as simple as possible for maintenance. But in odoo there several ways to do same thing just in the editor way.
Then imagine, with all the uses cases of your cutomers and ours and these of other contributors, it can be over complicated for now and futures versions.
Code comes from initial dev 6.1 version and needs to be review on some parts and try to become kiss (keep it simple as stupid) when possible. For that if user don't use package we have to :

  • hide package but always keep a package
  • map carrier_tracking_ref field of picking to parcel_tracking of package

2/ Your need to use a package for several picking is a very uncommon use case think. Maybe really specifics needs shouldn't determine common way to do things ? Problably you may think about merge picking before to deliver.
At akretion we'll port https://github.com/OCA/sale-workflow/tree/8.0/sale_order_merge to v12. Our needs is to only merge picking not sale order (I imagine that's the same for you)
On user side it seems confusing to share package across picking (which state of which object define you can add or not a product to package ?)

I hope it can help everybody to go the same solution

my 2 cents

from delivery-carrier.

bealdav avatar bealdav commented on July 17, 2024

Please @angelmoya could you have a look to Timo17100-c2c#1
I hope it can allow to use base_carrier_delivery_label for our both use
Thanks

from delivery-carrier.

github-actions avatar github-actions commented on July 17, 2024

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

from delivery-carrier.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.