[12.0] You can't have a date of next invoice anterior to the start of the contract line XX on pre-paid contract about contract

[Ismaw34]

On a 14 upgraded from 13 also happens.

[maisim]

@Ismaw34
Strange because it works here (14.0 runbot)
http://oca-contract-14-0-cab52350c3a3.runboat.odoo-community.org/web#id=5&action=413&model=contract.contract&view_type=form&cids=&menu_id=316

Probably because of this :

contract/contract/models/contract_line.py

Lines 466 to 467 in cab5235

	if line.display_type == "line_section" or not line.recurring_next_date:
	continue

Edit: I just try again on this link, I'm not able to save the contract if the invoice date < contract start date.
So same as on 12.0

[maisim]

12.0...maisim:contract:12.0

For 12.0, this do the trick

I will PR soon

[rafaelbn]

Hello @maisim ! I confirm this BUG in 12, 13 and 14

Did you made the PR? Before it, It would help really to check and review

• #841
• #852
• #853
• #854
• #893
• #899

[maisim]

Hi @rafaelbn,

Did you made the PR? Before it, It would help really to check and review

Not for the moment, I just did a quick fix, but I did not check for potential side effects

I also found others problem like bad computation of periods end (on montly, quarterly types) ... Thanks for the references I will look at it on the next week

[Ismaw34]

@Ismaw34 Strange because it works here (14.0 runbot) http://oca-contract-14-0-cab52350c3a3.runboat.odoo-community.org/web#id=5&action=413&model=contract.contract&view_type=form&cids=&menu_id=316

Probably because of this :

contract/contract/models/contract_line.py

Lines 466 to 467 in cab5235

	if line.display_type == "line_section" or not line.recurring_next_date:
	continue

Edit: I just try again on this link, I'm not able to save the contract if the invoice date < contract start date. So same as on 12.0

The issue happens here:

contract/contract/models/contract_line.py

Line 501 in cab5235

if (

The contract says for example, last date 03/31/2022 and next invoice 04/01/2022, says cant have the next invoice before the date of last invoice.
Thats weird because the next invoice is after the last date invoiced but still says is not.

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.